Skip to content

pallet revive: rpc build script should not panic#7786

Merged
ggwpez merged 8 commits intomasterfrom
oty-build-revive
Mar 5, 2025
Merged

pallet revive: rpc build script should not panic#7786
ggwpez merged 8 commits intomasterfrom
oty-build-revive

Conversation

@ggwpez
Copy link
Copy Markdown
Member

@ggwpez ggwpez commented Mar 3, 2025

This can error when you use cargo remote and probably also with cargo vendor.
Still seeing two more build errors, but at least this one is fixed.

Other one:

error: set `DATABASE_URL` to use query macros online, or run `cargo sqlx prepare` to update the query cache
   --> substrate/frame/revive/rpc/src/receipt_provider/db.rs:123:17
    |
123 |               let result = query!(
    |  __________________________^
124 | |                 r#"
125 | |                 INSERT OR REPLACE INTO transaction_hashes (transaction_hash, block_hash, transaction_index)
126 | |                 VALUES ($1, $2, $3)
...   |
130 | |                 transaction_index
131 | |             )

and (maybe Rust version related, this is 1.84.1)

error[E0282]: type annotations needed
   --> substrate/frame/revive/rpc/src/receipt_provider/db.rs:102:34
    |
102 |         let (tx_result, logs_result) = tokio::join!(delete_transaction_hashes, delete_logs);
    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot infer type
    |
    = note: this error originates in the macro `$crate::join` which comes from the expansion of the macro `tokio::join` (in Nightly builds, run with -Z macro-backtrace for more info)

ggwpez added 2 commits March 3, 2025 20:16
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested review from nprt and pgherveou and removed request for pgherveou March 3, 2025 19:19
@ggwpez
Copy link
Copy Markdown
Member Author

ggwpez commented Mar 3, 2025

/cmd prdoc --bump patch --audience runtime_dev

@ggwpez ggwpez added T3-RPC_API This PR/Issue is related to RPC APIs. T2-pallets This PR/Issue is related to a particular pallet. and removed T3-RPC_API This PR/Issue is related to RPC APIs. labels Mar 3, 2025
@ggwpez ggwpez changed the title Make revive rpc build script not panics pallet revive: rpc build script should not panic Mar 3, 2025
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@bkchr bkchr enabled auto-merge March 3, 2025 20:47
@bkchr bkchr added T2-pallets This PR/Issue is related to a particular pallet. and removed T2-pallets This PR/Issue is related to a particular pallet. labels Mar 3, 2025
@bkchr bkchr added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@ggwpez ggwpez added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@ggwpez ggwpez enabled auto-merge March 4, 2025 18:16
@paritytech-workflow-stopper
Copy link
Copy Markdown

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13660220496
Failed job name: test-linux-stable

@ggwpez ggwpez disabled auto-merge March 4, 2025 20:30
@ggwpez ggwpez enabled auto-merge March 4, 2025 20:30
@ggwpez ggwpez added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@ggwpez ggwpez added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
ggwpez added 2 commits March 5, 2025 12:35
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez enabled auto-merge March 5, 2025 11:52
@ggwpez ggwpez added this pull request to the merge queue Mar 5, 2025
Merged via the queue into master with commit 9100d24 Mar 5, 2025
244 of 253 checks passed
@ggwpez ggwpez deleted the oty-build-revive branch March 5, 2025 13:28
ordian added a commit that referenced this pull request Mar 6, 2025
* master:
  pallet-scheduler: Put back postponed tasks into the agenda (#7790)
  ci: update credentials for command-backport (#7798)
  [XCM] add generic location to account converter that also works with external ecosystems (#7313)
  [AHM] Make more stuff public (#7802)
  Support adding extra request-response protocols to the node (#7708)
  notifications/tests: Fix tests to avoid overflow on adding duration to instant (#7793)
  pallet revive: rpc build script should not panic (#7786)
  pallet-bridge-relayers - migrate benchmarks to v2 (#7531)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T2-pallets This PR/Issue is related to a particular pallet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants