Skip to content

[XCM] add generic location to account converter that also works with external ecosystems#7313

Merged
x3c41a merged 31 commits intoparitytech:masterfrom
Nathy-bajo:generic-location
Mar 5, 2025
Merged

[XCM] add generic location to account converter that also works with external ecosystems#7313
x3c41a merged 31 commits intoparitytech:masterfrom
Nathy-bajo:generic-location

Conversation

@Nathy-bajo
Copy link
Copy Markdown
Contributor

@Nathy-bajo Nathy-bajo commented Jan 23, 2025 •
edited by acatangiu
Loading

I added a new ExternalConsensusLocationsConverterFor struct to handle external global consensus locations and their child locations.
This struct extends the functionality of existing converters (GlobalConsensusParachainConvertsFor and EthereumLocationsConverterFor) while maintaining backward compatibility.

Fixes #7129

Polkadot address: 121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1

@Nathy-bajo Nathy-bajo requested a review from a team as a code owner January 23, 2025 13:07
@acatangiu acatangiu changed the title [XCM] add generic location to account converter #7129 [XCM] add generic location to account converter that also works with external ecosystems Jan 23, 2025
@Nathy-bajo
Copy link
Copy Markdown
Contributor Author

Nathy-bajo commented Jan 27, 2025

Please review @acatangiu

acatangiu
acatangiu reviewed Jan 27, 2025
View reviewed changes
@acatangiu acatangiu marked this pull request as draft January 27, 2025 17:18
@Nathy-bajo Nathy-bajo marked this pull request as ready for review February 11, 2025 13:00
@Nathy-bajo
Copy link
Copy Markdown
Contributor Author

Nathy-bajo commented Feb 11, 2025 •
edited
Loading

@acatangiu I'm still a bit confused but I tried following your explanation.

@Nathy-bajo Nathy-bajo requested a review from acatangiu February 12, 2025 10:25
acatangiu
acatangiu reviewed Feb 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are on the right track

Nathy-bajo and others added 6 commits February 19, 2025 15:30
@Nathy-bajo Nathy-bajo requested a review from acatangiu February 19, 2025 15:12
@Nathy-bajo
Copy link
Copy Markdown
Contributor Author

Nathy-bajo commented Feb 19, 2025

Can you help review this please @acatangiu

acatangiu
acatangiu reviewed Feb 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Now you need to add tests.

You can extend this test with more conversions.

Please also add explicit checks to the test that verify the new ExternalConsensusLocationsConverterFor converts locations previously covered by GlobalConsensusParachainConvertsFor and EthereumLocationsConverterFor with the same results.

@Nathy-bajo @acatangiu
Update polkadot/xcm/xcm-builder/src/location_conversion.rs
605364e 
Co-authored-by: Adrian Catangiu <adrian@parity.io>
@acatangiu
Copy link
Copy Markdown
Contributor

acatangiu commented Feb 28, 2025

@x3c41a can you please help add the required tests here?

@x3c41a x3c41a added this pull request to the merge queue Mar 5, 2025
Merged via the queue into paritytech:master with commit 1dbaeba Mar 5, 2025
247 of 254 checks passed
@x3c41a x3c41a mentioned this pull request Mar 5, 2025
Merged
@yrong yrong mentioned this pull request Mar 5, 2025
Merged
@Nathy-bajo Nathy-bajo deleted the generic-location branch March 5, 2025 17:50
ordian added a commit that referenced this pull request Mar 6, 2025
@ordian
Merge branch 'master' into ao-governance-manual-slash
4d46726 
* master:
  pallet-scheduler: Put back postponed tasks into the agenda (#7790)
  ci: update credentials for command-backport (#7798)
  [XCM] add generic location to account converter that also works with external ecosystems (#7313)
  [AHM] Make more stuff public (#7802)
  Support adding extra request-response protocols to the node (#7708)
  notifications/tests: Fix tests to avoid overflow on adding duration to instant (#7793)
  pallet revive: rpc build script should not panic (#7786)
  pallet-bridge-relayers - migrate benchmarks to v2 (#7531)
github-merge-queue bot pushed a commit that referenced this pull request Mar 6, 2025
@x3c41a
[XCM] Add generic location to account converter that also works with …
d5bd15b 
…external ecosystems for bridge hubs (#7809)

That's the continuation of
[PR#7313](#7313)
@vgeddes vgeddes mentioned this pull request Mar 26, 2025
Closed
@acatangiu acatangiu added the A4-backport-stable2503 Pull request must be backported to the stable2503 release branch label Mar 26, 2025
@paritytech-release-backport-bot
Copy link
Copy Markdown

paritytech-release-backport-bot bot commented Mar 26, 2025

Created backport PR for stable2503:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7313-to-stable2503
git worktree add --checkout .worktree/backport-7313-to-stable2503 backport-7313-to-stable2503
cd .worktree/backport-7313-to-stable2503
git reset --hard HEAD^
git cherry-pick -x 1dbaeba9044ef491847a8204da98cd9e74534cdb
git push --force-with-lease

@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request Mar 26, 2025
Merged
acatangiu added a commit that referenced this pull request Mar 26, 2025
@Nathy-bajo @acatangiu @x3c41a
[XCM] add generic location to account converter that also works with …
f8f2cfc 
…external ecosystems (#7313)

I added a new `ExternalConsensusLocationsConverterFor` struct to handle
external global consensus locations and their child locations.
This struct extends the functionality of existing converters
(`GlobalConsensusParachainConvertsFor` and
`EthereumLocationsConverterFor`) while maintaining backward
compatibility.

Fixes #7129

Polkadot address: 121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1

---------

Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: ndk <ndk@parity.io>
EgorPopelyaev pushed a commit that referenced this pull request Mar 26, 2025
@paritytech-release-backport-bot @Nathy-bajo
@acatangiu @x3c41a
[stable2503] Backport #7313 (#8048)
16658b1 
Backport #7313 into `stable2503` from Nathy-bajo.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Nathaniel Bajo <73991674+Nathy-bajo@users.noreply.github.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: ndk <ndk@parity.io>
vgeddes pushed a commit to vgeddes/polkadot-sdk that referenced this pull request Mar 27, 2025
@paritytech-release-backport-bot @Nathy-bajo
@acatangiu @x3c41a @vgeddes
[stable2503] Backport paritytech#7313 (paritytech#8048)
ecf58c9 
Backport paritytech#7313 into `stable2503` from Nathy-bajo.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Nathaniel Bajo <73991674+Nathy-bajo@users.noreply.github.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: ndk <ndk@parity.io>
(cherry picked from commit 16658b1)
@ggwpez ggwpez mentioned this pull request Jun 4, 2025
Merged
7 tasks
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Closed
This was referenced Jul 16, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@x3c41a x3c41a x3c41a approved these changes

@acatangiu acatangiu acatangiu approved these changes

+2 more reviewers

@yrong yrong yrong approved these changes

@raymondkfcheung raymondkfcheung raymondkfcheung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@x3c41a x3c41a

Labels

A4-backport-stable2503 Pull request must be backported to the stable2503 release branch T6-XCM This PR/Issue is related to XCM.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[XCM] add generic location to account converter for locations in external ecosystems

7 participants

@Nathy-bajo @acatangiu @x3c41a @yrong @raymondkfcheung @pgherveou @patriciobcs