Skip to content

[stable2409] Backport #7011#7052

Closed
paritytech-cmd-bot-polkadot-sdk[bot] wants to merge 1 commit intostable2409from
backport-7011-to-stable2409
Closed

[stable2409] Backport #7011#7052
paritytech-cmd-bot-polkadot-sdk[bot] wants to merge 1 commit intostable2409from
backport-7011-to-stable2409

Conversation

@paritytech-cmd-bot-polkadot-sdk
Copy link
Copy Markdown
Contributor

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot commented Jan 6, 2025

Backport #7011 into stable2409 from dmitry-markin.

See the documentation on how to use this bot.

@dmitry-markin @bkchr @github-actions
sync: Send already connected peers to new subscribers (#7011)
20779d4 
Introduce `SyncEvent::InitialPeers` message sent to new subscribers to
allow them correctly tracking sync peers. This resolves a race condition
described in
#6573 (comment).

Fixes #6573.

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <git@kchr.de>
(cherry picked from commit b4177a9)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Jan 6, 2025
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jan 6, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@dmitry-markin
Copy link
Copy Markdown
Contributor

dmitry-markin commented Jan 6, 2025

Closing. We don't need this in stable2409 as the issue doesn't manifest there due to present NetworkStarter.

@EgorPopelyaev EgorPopelyaev deleted the backport-7011-to-stable2409 branch July 17, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dmitry-markin