sync: Send already connected peers to new subscribers#7011
Merged
dmitry-markin merged 5 commits intomasterfrom Dec 30, 2024
Merged
sync: Send already connected peers to new subscribers#7011dmitry-markin merged 5 commits intomasterfrom
dmitry-markin merged 5 commits intomasterfrom
Conversation
Contributor
Author
|
/cmd prdoc --audience node_dev --bump major |
Co-authored-by: Bastian Köcher <git@kchr.de>
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
skunert
approved these changes
Dec 30, 2024
pepoviola
reviewed
Dec 30, 2024
Contributor
pepoviola
left a comment
pepoviola
left a comment
There was a problem hiding this comment.
Nice! Thanks @dmitry-markin 🙌
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
Introduce `SyncEvent::InitialPeers` message sent to new subscribers to allow them correctly tracking sync peers. This resolves a race condition described in paritytech#6573 (comment). Fixes paritytech#6573. --------- Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <git@kchr.de>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
Introduce `SyncEvent::InitialPeers` message sent to new subscribers to allow them correctly tracking sync peers. This resolves a race condition described in #6573 (comment). Fixes #6573. --------- Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <git@kchr.de> (cherry picked from commit b4177a9)
Contributor
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
Introduce `SyncEvent::InitialPeers` message sent to new subscribers to allow them correctly tracking sync peers. This resolves a race condition described in #6573 (comment). Fixes #6573. --------- Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <git@kchr.de> (cherry picked from commit b4177a9)
Contributor
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
Introduce `SyncEvent::InitialPeers` message sent to new subscribers to allow them correctly tracking sync peers. This resolves a race condition described in #6573 (comment). Fixes #6573. --------- Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <git@kchr.de> (cherry picked from commit b4177a9)
Contributor
|
Successfully created backport PR for |
dmitry-markin
had a problem deploying
to
subsystem-benchmarks
GitHub Actions
Failure
ordian
added a commit
that referenced
this pull request
Jan 7, 2025
* master: (256 commits) fix chunk fetching network compatibility zombienet test (#6988) chore: delete repeat words (#7034) Print taplo version in CI (#7041) Implement cumulus StorageWeightReclaim as wrapping transaction extension + frame system ReclaimWeight (#6140) Make `TransactionExtension` tuple of tuple transparent for implication (#7028) Replace duplicated whitelist with whitelisted_storage_keys (#7024) [WIP] Fix networking-benchmarks (#7036) [docs] Fix release naming (#7032) migrate pallet-mixnet to umbrella crate (#6986) Improve remote externalities logging (#7021) Fix polkadot sdk doc. (#7022) Remove warning log from frame-omni-bencher CLI (#7020) [pallet-revive] fix file case (#6981) Add workflow for networking benchmarks (#7029) [CI] Skip SemVer on R0-silent and update docs (#6285) correct path in cumulus README (#7001) sync: Send already connected peers to new subscribers (#7011) Excluding chainlink domain for link checker CI (#6524) pallet-bounties: Fix benchmarks for 0 ED (#7013) Log peerset set ID -> protocol name mapping (#7005) ...
EgorPopelyaev
pushed a commit
that referenced
this pull request
Jan 14, 2025
Backport #7011 into `stable2412` from dmitry-markin. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Dmitry Markin <dmitry@markin.tech>
dmitry-markin
added a commit
that referenced
this pull request
Jan 27, 2025
This reverts commit b4177a9.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
…rd-compatible) (#7344) Revert #7011 and replace it with a backward-compatible solution suitable for backporting to a release branch. ### Review notes It's easier to review this PR per commit: the first commit is just a revert, so it's enough to review only the second one, which is almost a one-liner. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jan 27, 2025
…rd-compatible) (#7344) Revert #7011 and replace it with a backward-compatible solution suitable for backporting to a release branch. ### Review notes It's easier to review this PR per commit: the first commit is just a revert, so it's enough to review only the second one, which is almost a one-liner. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit ee30ec7)
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
SyncEvent::InitialPeersmessage sent to new subscribers to allow them correctly tracking sync peers. This resolves a race condition described in #6573 (comment).Fixes #6573.