templates: add genesis config presets for minimal/solochain#5868
Merged
iulianbarbu merged 17 commits intoparitytech:masterfrom Oct 5, 2024
Merged
templates: add genesis config presets for minimal/solochain#5868iulianbarbu merged 17 commits intoparitytech:masterfrom
iulianbarbu merged 17 commits intoparitytech:masterfrom
Conversation
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
This reverts commit 2175419.
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Contributor
|
Regarding #4739 (comment) Do we really need these functions? They look like some generic wrappers around |
Contributor
@michalkucharczyk this is (partially) addressed here: #5705 and almost done here: #5804 |
Contributor
Author
skunert
reviewed
Oct 1, 2024
Signed-off-by: Iulian Barbu <[email protected]>
skunert
approved these changes
Oct 1, 2024
Signed-off-by: Iulian Barbu <[email protected]>
michalkucharczyk
approved these changes
Oct 2, 2024
ffarall
added a commit
to datahaven-xyz/datahaven
that referenced
this pull request
Apr 14, 2025
Based on paritytech/polkadot-sdk#5868. Note: this (somehow) breaks the ability to run a local network with the zombienet config. It seems that the config generated by Zombienet that automatically set the balance of validators is leading to an issue (because of the address type). --------- Co-authored-by: Facundo Farall <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #5790. Useful for starting nodes based on minimal/solochain when doing development or for testing omni node with less happy code paths. It is reusing the presets defined for the nodes chain specs.
Integration
Specifically useful for development/testing if generating chain-specs for
minimalorsolochainruntimes fromtemplatesdirectories.Review Notes
Added
genesis_config_presetsmodules for both minimal/solochain. I reused the presets defined in each nodechain_specmodule correspondingly.PRDOC
Not sure who uses templates, maybe node devs and runtime devs at start of their learning journey, but happy to get some guidance on how to write the prdoc if needed.
Thinking out loud
I saw concerns around sharing functionality for such genesis config presets between the template chains. I think there might be a case for doing that, on the lines of this comment: #4739 (comment). I would add that
parachains-common::genesis_config_helepercontains a few methods from those mentioned, but I am unsure if using it as a dependency for templates is correct. Feels like the comment suggests there should be acommonscrate concerning justtemplates, which I agree with to some degree, if we assumecumulusneeds might be driven in certain directions that are not relevant totemplatesand vice versa. However I am not so certain about this, so would welcome some thoughts, since I am seeingparachains-commonbeing used already in a few runtime implementations: https://crates.io/crates/parachains-common/reverse_dependencies?page=3, so might be a good candidate already for thecommonlogic.