Skip to content

Refactor get_account_id_from_seed / get_from_seed to one common place#5804

Merged
iulianbarbu merged 39 commits intoparitytech:masterfrom
programskillforverification:refactor-get_account_id_from_seed
Oct 17, 2024
Merged

Refactor get_account_id_from_seed / get_from_seed to one common place#5804
iulianbarbu merged 39 commits intoparitytech:masterfrom
programskillforverification:refactor-get_account_id_from_seed

Conversation

@programskillforverification
Copy link
Copy Markdown
Contributor

@programskillforverification programskillforverification commented Sep 23, 2024 •
edited by bkontur
Loading

Closes #5705

@michalkucharczyk michalkucharczyk self-requested a review September 23, 2024 10:26
This was referenced Sep 27, 2024
Closed
Merged
Merged
@iulianbarbu iulianbarbu mentioned this pull request Oct 1, 2024
Closed
@programskillforverification programskillforverification marked this pull request as ready for review October 1, 2024 15:31
@programskillforverification programskillforverification requested a review from a team as a code owner October 1, 2024 15:31
@programskillforverification programskillforverification marked this pull request as draft October 1, 2024 15:31
@iulianbarbu iulianbarbu requested review from iulianbarbu and removed request for a team October 1, 2024 15:42
iulianbarbu
iulianbarbu reviewed Oct 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@iulianbarbu iulianbarbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are usages of get_account_id_from_seed in templates/parachain/runtime/src/genesis_config_presets.rs, can you update this too?

Not sure what IDE you're using, but if it is using rust-analyzer it might see the errors there if you set WASM_BUILD_CARGO_ARGS="--message-format=json" in the environment before starting your IDE and waiting for a full build/indexing. Also, please mark this PR as ready for review as soon as you changed everything you wanted (merging it with latest master might be a good thing to do before then too).

michalkucharczyk
michalkucharczyk reviewed Oct 3, 2024
View reviewed changes
@programskillforverification programskillforverification marked this pull request as ready for review October 7, 2024 09:19
iulianbarbu
iulianbarbu reviewed Oct 8, 2024
View reviewed changes
davxy
davxy requested changes Oct 17, 2024
View reviewed changes
michalkucharczyk
michalkucharczyk reviewed Oct 17, 2024
View reviewed changes
@programskillforverification programskillforverification force-pushed the refactor-get_account_id_from_seed branch from 87ce254 to 341c689 Compare October 17, 2024 10:29
michalkucharczyk
michalkucharczyk reviewed Oct 17, 2024
View reviewed changes
michalkucharczyk
michalkucharczyk reviewed Oct 17, 2024
View reviewed changes
michalkucharczyk
michalkucharczyk reviewed Oct 17, 2024
View reviewed changes
@programskillforverification @michalkucharczyk
Update substrate/primitives/keyring/src/ed25519.rs
b1fcb7f 
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
@programskillforverification @michalkucharczyk
Update substrate/primitives/keyring/src/sr25519.rs
d9ca423 
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
@programskillforverification @michalkucharczyk
Update substrate/primitives/keyring/src/lib.rs
5860e2d 
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
@iulianbarbu iulianbarbu enabled auto-merge October 17, 2024 12:11
@iulianbarbu iulianbarbu added this pull request to the merge queue Oct 17, 2024
@iulianbarbu iulianbarbu removed this pull request from the merge queue due to a manual request Oct 17, 2024
@iulianbarbu iulianbarbu added this pull request to the merge queue Oct 17, 2024
Merged via the queue into paritytech:master with commit a2c7575 Oct 17, 2024
@bkchr
Copy link
Copy Markdown
Member

bkchr commented Oct 18, 2024

/tip small

@substrate-tip-bot
Copy link
Copy Markdown

substrate-tip-bot bot commented Oct 18, 2024

@bkchr A referendum for a small (20 DOT) tip was successfully submitted for @programskillforverification (12gcYUJzFF4x2kdBAZu5zbRd6o7HitBb3iRMuiVtemYuvBEt on polkadot).

Referendum number: 1244.
tip

@substrate-tip-bot
Copy link
Copy Markdown

substrate-tip-bot bot commented Oct 18, 2024

The referendum has appeared on Polkassembly.

@programskillforverification
Copy link
Copy Markdown
Contributor Author

programskillforverification commented Oct 21, 2024

/tip small

Thanks

@github-actions github-actions bot mentioned this pull request Feb 26, 2025
Closed
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@iulianbarbu iulianbarbu iulianbarbu approved these changes

@davxy davxy davxy approved these changes

Assignees

@programskillforverification programskillforverification

Labels

T17-primitives Changes to primitives that are not covered by any other label.

Projects

[preview] release tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor get_account_id_from_seed / get_from_seed to one common place

6 participants

@programskillforverification @michalkucharczyk @bkchr @davxy @iulianbarbu @pgherveou