Skip to content

Bump parity-common#5673

Closed
pgherveou wants to merge 7 commits intomasterfrom
pg/bump-uint
Closed

Bump parity-common#5673
pgherveou wants to merge 7 commits intomasterfrom
pg/bump-uint

Conversation

@pgherveou
Copy link
Copy Markdown
Contributor

@pgherveou pgherveou commented Sep 11, 2024 •
edited
Loading

pgherveou
pgherveou commented Sep 11, 2024
View reviewed changes
@pgherveou pgherveou added the dependencies Pull requests that update a dependency file label Sep 11, 2024
@pgherveou pgherveou changed the title Bumping parity-common Bump parity-common Sep 11, 2024
@pgherveou pgherveou mentioned this pull request Sep 11, 2024
Merged
@ordian
Copy link
Copy Markdown
Contributor

ordian commented Sep 11, 2024 

$ cargo tree -i -p [email protected] | less

primitive-types v0.12.1
└── sp-runtime-interface v17.0.0 (https://github.com/paritytech/polkadot-sdk#82912acb)
    └── sp-crypto-ec-utils v0.4.1 (https://github.com/paritytech/polkadot-sdk#82912acb)
        ├── sp-ark-bls12-381 v0.4.2 (https://github.com/paritytech/arkworks-substrate#caa2eed7)
        │   └── bandersnatch_vrfs v0.0.4 (https://github.com/w3f/ring-vrf?rev=0fef826#0fef8266)
        │       └── sp-core v28.0.0 (/Users/andronik/code/polkadot-sdk/substrate/primitives/core)

Not sure what is the right sequence of updating these deps anymore
This looks like a circular dependency to me 😬 https://github.com/paritytech/arkworks-substrate/blob/caa2eed74beb885dd07c7db5f916f2281dad818f/Cargo.toml#L32

@pgherveou pgherveou mentioned this pull request Sep 11, 2024
Closed
@pgherveou pgherveou marked this pull request as ready for review September 12, 2024 11:37
@pgherveou pgherveou added dependencies Pull requests that update a dependency file D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. and removed dependencies Pull requests that update a dependency file labels Sep 12, 2024
@pgherveou pgherveou requested a review from a team as a code owner September 12, 2024 12:09
ordian
ordian reviewed Oct 2, 2024
View reviewed changes
Cargo.toml
ethabi = { version = "1.0.0", default-features = false, package = "ethabi-decode" }
ethbloom = { version = "0.13.0", default-features = false }
ethereum-types = { version = "0.14.1", default-features = false }
ethabi = { version = "1.1.0", default-features = false, package = "ethabi-decode" }
Copy link
Copy Markdown
Contributor

@ordian ordian Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ethabi = { version = "1.1.0", default-features = false, package = "ethabi-decode" }
ethabi = { version = "2.0.0", default-features = false, package = "ethabi-decode" }

@pgherveou
Copy link
Copy Markdown
Contributor Author

pgherveou commented Oct 8, 2024

dup #5886

@pgherveou pgherveou closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ordian ordian ordian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pgherveou @ordian