Conversation
niklasad1
reviewed
Sep 11, 2024
| [package] | ||
| name = "rlp-derive" | ||
| version = "0.1.0" | ||
| version = "0.2.0" |
Contributor
There was a problem hiding this comment.
why breaking change in the derive crate but not in the rlp?
Contributor
There was a problem hiding this comment.
I see it was MSRV bump but probably applies to rlp as well because it depends on rlp-derive?!
Contributor
Author
There was a problem hiding this comment.
It is a breaking change for rlp as well. I've accidentally published rlp 0.6.0 with rlp-derive versioned at 0.1.0 and then yanked that version. So it will go from 0.5.2 to 0.6.1 (already published).
niklasad1
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
missed in #860
it was published already