Skip to content

Remove unused feature gated code from the minimal template#5237

Merged
rzadp merged 1 commit intomasterfrom
rzadp/minimal-template-features
Aug 5, 2024
Merged

Remove unused feature gated code from the minimal template#5237
rzadp merged 1 commit intomasterfrom
rzadp/minimal-template-features

Conversation

@rzadp
Copy link
Contributor

@rzadp rzadp commented Aug 5, 2024

There is no actual try-runtime or runtime-benchmarks functionality in the minimal template at the moment.

@rzadp rzadp added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Aug 5, 2024
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense!

@rzadp rzadp added this pull request to the merge queue Aug 5, 2024
Merged via the queue into master with commit 035211d Aug 5, 2024
@rzadp rzadp deleted the rzadp/minimal-template-features branch August 5, 2024 12:19
ordian added a commit that referenced this pull request Aug 6, 2024
* master: (51 commits)
  Remove unused feature gated code from the minimal template (#5237)
  make polkadot-parachain startup errors pretty (#5214)
  Coretime auto-renew (#4424)
  network/strategy: Backoff and ban overloaded peers to avoid submitting the same request multiple times (#5029)
  Fix frame crate usage doc (#5222)
  beefy: Tolerate pruned state on runtime API call (#5197)
  rpc: Enable ChainSpec for polkadot-parachain (#5205)
  Add an adapter for configuring AssetExchanger (#5130)
  Replace env_logger with sp_tracing (#5065)
  Adjust sync templates flow to use new release branch (#5182)
  litep2p/discovery: Publish authority records with external addresses only (#5176)
  Run UI tests in CI for some other crates (#5167)
  Remove `pallet::getter` usage from the pallet-balances (#4967)
  pallet-timestamp: `UnixTime::now` implementation logs error only if called at genesis (#5055)
  [CI] Cache try-runtime check (#5179)
  [Backport] version bumps and the prdocs reordering from stable2407 (#5178)
  [subsystem-benchmark] Update availability-distribution-regression-bench baseline after recent subsystem changes (#5180)
  Remove pallet::getter usage from proxy (#4963)
  Remove pallet::getter macro usage from pallet-election-provider-multi-phase (#4487)
  Review-bot@2.6.0 (#5177)
  ...
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Aug 28, 2024
…h#5237)

- Progresses paritytech#5226

There is no actual `try-runtime` or `runtime-benchmarks` functionality
in the minimal template at the moment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants