rpc: Enable ChainSpec for polkadot-parachain by lexnv · Pull Request #5205 · paritytech/polkadot-sdk

lexnv · 2024-08-01T11:39:02Z

This PR enables the chainSpec_v1 class for the polkadot-parachian.
The chainSpec is part of the rpc-v2 which is spec-ed at: https://github.com/paritytech/json-rpc-interface-spec/blob/main/src/api/chainSpec.md.

This also paves the way for enabling a future chainSpec_unstable_spec on all nodes.

Closes: #5191

cc @paritytech/subxt-team

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

This reverts commit 2675d44.

skunert · 2024-08-01T13:07:53Z

cumulus/polkadot-parachain/src/service.rs

 				let backend_for_rpc = backend.clone();

-				Box::new(move |deny_unsafe, _| {
+				Box::new(move |deny_unsafe: sc_rpc::DenyUnsafe, _| {


Why is the type needed now in contrast to before?

I think I've hit the autocomplete by mistake :D No longer needed since I was able to obtain the same by moving the initialization to the substrate builder

This reverts commit cc90001. Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

paritytech-cicd-pr · 2024-08-01T13:30:06Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6882564

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv · 2024-08-01T13:47:30Z

Testing done:

with this patch

curl -H "Content-Type: application/json" -d '{"id":1, "jsonrpc":"2.0", "method": "rpc_methods", "params":[1]}' http://localhost:9944                                                                                                                            
{"jsonrpc":"2.0","result":{"methods":["account_nextIndex","...",".. ,"chainSpec_v1_chainName","chainSpec_v1_genesisHash","chainSpec_v1_properties",

without

{"jsonrpc":"2.0","result":{"methods":["account_nextIndex","author_hasKey","author_hasSessionKeys","author_insertKey","author_pendingExtrinsics","author_removeExtrinsic","author_rotateKeys","author_submitAndWatchExtrinsic","author_submitExtrinsic","author_unwatchExtrinsic","chainHead_v1_body","chainHead_v1_call","chainHead_v1_continue","chainHead_v1_follow","chainHead_v1_header","chainHead_v1_stopOperation","chainHead_v1_storage","chainHead_v1_unfollow","chainHead_v1_unpin","chain_getBlock","chain_getBlockHash","chain_getFinalisedHead","chain_getFinalizedHead","chain_getHead","chain_getHeader","chain_getRuntimeVersion","chain_subscribeAllHeads","chain_subscribeFinalisedHeads","chain_subscribeFinalizedHeads","chain_subscribeNewHead","chain_subscribeNewHeads","chain_subscribeRuntimeVersion","chain_unsubscribeAllHeads","chain_unsubscribeFinalisedHeads","chain_unsubscribeFinalizedHeads","chain_unsubscribeNewHead","chain_unsubscribeNewHeads","chain_unsubscribeRuntimeVersion","childstate_getKeys","childstate_getKeysPaged","childstate_getKeysPagedAt","childstate_getStorage","childstate_getStorageEntries","childstate_getStorageHash","childstate_getStorageSize","dev_getBlockStats","offchain_localStorageGet","offchain_localStorageSet","payment_queryFeeDetails","payment_queryInfo","rpc_methods","state_call","state_callAt","state_getChildReadProof","state_getKeys","state_getKeysPaged","state_getKeysPagedAt","state_getMetadata","state_getPairs","state_getReadProof","state_getRuntimeVersion","state_getStorage","state_getStorageAt","state_getStorageHash","state_getStorageHashAt","state_getStorageSize","state_getStorageSizeAt","state_queryStorage","state_queryStorageAt","state_subscribeRuntimeVersion","state_subscribeStorage","state_traceBlock","state_trieMigrationStatus","state_unsubscribeRuntimeVersion","state_unsubscribeStorage","subscribe_newHead","system_accountNextIndex","system_addLogFilter","system_addReservedPeer","system_chain","system_chainType","system_dryRun","system_dryRunAt","system_health","system_localListenAddresses","system_localPeerId","system_name","system_nodeRoles","system_peers","system_properties","system_removeReservedPeer","system_reservedPeers","system_resetLogFilter","system_syncState","system_unstable_networkState","system_version","transactionWatch_v1_submitAndWatch","transactionWatch_v1_unwatch","transaction_v1_broadcast","transaction_v1_stop","unsubscribe_newHead"]},"id":1}

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

niklasad1 · 2024-08-01T13:50:57Z

Nice one, with this refactor now all users of polkadot-sdk gets the entire rpc v2 API without having to use their own rpc extensions for it.

niklasad1 · 2024-08-01T13:56:06Z

prdoc/pr_5205.prdoc

+    - Runtime Dev
+    - Node Dev
+    description: |
+      Enables the `chainSpec_v1` rpc-v2 API for polkadot-parachains.


I would like to re-phrase this as:

The substrate-service-builder now includes the entire rpc v2 API. The chainspec API was previously defined as rpc extension where for instance chains would need to enable it explicitly for it to be enabled which isn't the case anymore

niklasad1

Nice 👍

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* master: (51 commits) Remove unused feature gated code from the minimal template (#5237) make polkadot-parachain startup errors pretty (#5214) Coretime auto-renew (#4424) network/strategy: Backoff and ban overloaded peers to avoid submitting the same request multiple times (#5029) Fix frame crate usage doc (#5222) beefy: Tolerate pruned state on runtime API call (#5197) rpc: Enable ChainSpec for polkadot-parachain (#5205) Add an adapter for configuring AssetExchanger (#5130) Replace env_logger with sp_tracing (#5065) Adjust sync templates flow to use new release branch (#5182) litep2p/discovery: Publish authority records with external addresses only (#5176) Run UI tests in CI for some other crates (#5167) Remove `pallet::getter` usage from the pallet-balances (#4967) pallet-timestamp: `UnixTime::now` implementation logs error only if called at genesis (#5055) [CI] Cache try-runtime check (#5179) [Backport] version bumps and the prdocs reordering from stable2407 (#5178) [subsystem-benchmark] Update availability-distribution-regression-bench baseline after recent subsystem changes (#5180) Remove pallet::getter usage from proxy (#4963) Remove pallet::getter macro usage from pallet-election-provider-multi-phase (#4487) Review-bot@2.6.0 (#5177) ...

lexnv added 2 commits August 1, 2024 14:27

cumulus: Add chain spec to the build_rpc_extensions

2675d44

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

cumulus: Enable ChainSpec for polkadot-parachain

cc90001

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv added I5-enhancement An additional feature request. T3-RPC_API This PR/Issue is related to RPC APIs. T9-cumulus This PR/Issue is related to cumulus. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Aug 1, 2024

lexnv self-assigned this Aug 1, 2024

Add PR doc

236ee3a

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv requested a review from a team August 1, 2024 11:44

dmitry-markin approved these changes Aug 1, 2024

View reviewed changes

dmitry-markin requested a review from a team August 1, 2024 11:52

Revert "cumulus: Add chain spec to the build_rpc_extensions"

2469101

This reverts commit 2675d44.

skunert reviewed Aug 1, 2024

View reviewed changes

skunert approved these changes Aug 1, 2024

View reviewed changes

lexnv added 2 commits August 1, 2024 16:23

Revert "cumulus: Enable ChainSpec for polkadot-parachain"

cf14833

This reverts commit cc90001. Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

builder: Move init chainSpec to substrate builder

6c11c15

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv changed the title ~~cumulus: Enable ChainSpec for polkadot-parachain~~ rpc: Enable ChainSpec for polkadot-parachain Aug 1, 2024

Fix clippy

f705a93

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Update prdoc

86177bd

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

niklasad1 reviewed Aug 1, 2024

View reviewed changes

niklasad1 approved these changes Aug 1, 2024

View reviewed changes

lexnv and others added 3 commits August 1, 2024 17:03

Update prdoc

70f03e6

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

prdoc: Patch polkadot-rpc

6a00f91

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Merge branch 'master' into lexnv/chain-spec-enable

1cc7f2f

lexnv added this pull request to the merge queue Aug 2, 2024

Merged via the queue into master with commit ce6938a Aug 2, 2024

lexnv deleted the lexnv/chain-spec-enable branch August 2, 2024 15:45

niklasad1 mentioned this pull request Aug 31, 2024

JSON-RPC: Missing Chainspec methods #5539

Closed

2 tasks

github-actions bot mentioned this pull request Oct 8, 2024

Update polkadot-sdk from stable2407 to stable2409 moonbeam-foundation/moonbeam#2994

Closed

github-actions bot mentioned this pull request Dec 5, 2024

Update polkadot-sdk from stable2407 to stable2409-2 moonbeam-foundation/moonbeam#3075

Closed

ashutoshvarma mentioned this pull request Apr 23, 2025

[Uplift] polkadot-sdk stable2409 uplift AstarNetwork/Astar#1404

Closed

pgherveou added this to [preview] release tracker Mar 20, 2026

github-project-automation bot moved this to Todo in [preview] release tracker Mar 20, 2026

github-project-automation bot moved this from Todo to Done in [preview] release tracker Mar 20, 2026

pgherveou removed this from [preview] release tracker Mar 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rpc: Enable ChainSpec for polkadot-parachain#5205

rpc: Enable ChainSpec for polkadot-parachain#5205
lexnv merged 11 commits intomasterfrom
lexnv/chain-spec-enable

lexnv commented Aug 1, 2024 •

edited

Loading

Uh oh!

skunert Aug 1, 2024

Uh oh!

lexnv Aug 1, 2024

Uh oh!

paritytech-cicd-pr commented Aug 1, 2024

Uh oh!

lexnv commented Aug 1, 2024

Uh oh!

niklasad1 commented Aug 1, 2024

Uh oh!

niklasad1 Aug 1, 2024

Uh oh!

niklasad1 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

lexnv commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skunert Aug 1, 2024

Choose a reason for hiding this comment

Uh oh!

lexnv Aug 1, 2024

Choose a reason for hiding this comment

Uh oh!

paritytech-cicd-pr commented Aug 1, 2024

Uh oh!

lexnv commented Aug 1, 2024

Uh oh!

niklasad1 commented Aug 1, 2024

Uh oh!

niklasad1 Aug 1, 2024

Choose a reason for hiding this comment

Uh oh!

niklasad1 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lexnv commented Aug 1, 2024 •

edited

Loading