Fix region nonfungible implementation#5067
Conversation
I added two new tests. They don't explicitly check for the coremask, but if the coremask changed when minting, the region returned would be the old one which still has the owner set to |
|
Looks good, just needs a prdoc. I just realised it's breaking as |
But it is not exposed as an extrinsic; it can only be accessed from the runtime code, right? |
Co-authored-by: Dónal Murray <donalm@seadanda.dev>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
The semver CI check should be fixed no master, please try again after merging it in. |
cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs
Outdated
Show resolved
Hide resolved
bkontur
left a comment
There was a problem hiding this comment.
lgtm, just nits with import (can be also ignored)
cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
|
The semver check was failing. Maybe merging with the master branch again will fix it? |
The problem with the current implementation is that minting will cause the region coremask to be set to `Coremask::complete` regardless of the actual coremask. This PR fixes that. More details about the nonfungible implementation can be found here: paritytech#3455 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
The problem with the current implementation is that minting will cause the region coremask to be set to
Coremask::completeregardless of the actual coremask.This PR fixes that.
More details about the nonfungible implementation can be found here: #3455