XCM coretime region transfers by Szegoo · Pull Request #3455 · paritytech/polkadot-sdk

Szegoo · 2024-02-23T09:56:16Z

This PR introduces changes enabling the transfer of coretime regions via XCM.

TL;DR: There are two primary issues that are resolved in this PR:

The mint and burn functions were not implemented for coretime regions. These operations are essential for moving assets to and from the XCM holding register.
The transfer of non-fungible assets through XCM was previously disallowed. This was due to incorrectly benchmarking non-fungible asset transfers via XCM, which led to assigning it a weight of Weight::Max, effectively preventing its execution.

`mint_into` and `burn` implementation

This PR addresses the issue with cross-chain transferring regions back to the Coretime chain. Remote reserve transfers are performed by withdrawing and depositing the asset to and from the holding registry. This requires the asset to support burning and minting functionality.

This PR adds burning and minting; however, they work a bit differently than usual so that the associated region record is not lost when burning. Instead of removing all the data, burning will set the owner of the region to None, and when minting it back, it will set it to an actual value. So, when cross-chain transferring, withdrawing into the registry will remove the region from its original owner, and when depositing it from the registry, it will set its owner to another account

This was originally implemented in this PR: #3455, however we decided to move all of it to this single PR (#3455 (comment))

Fixes made in this PR

Update the XcmReserveTransferFilter on coretime chain since it is meant as a reserve chain for coretime regions.
Update the XCM benchmark to use AssetTransactor instead of assuming pallet-balances for fungible transfers.
Update the XCM benchmark to properly measure weight consumption for nonfungible reserve asset transfers. ATM reserve transfers via the extrinsic do not work since the weight for it is set to Weight::max().

Closes: #865

Szegoo · 2024-02-27T12:51:37Z

The benchmark for the coretime chain should be re-run since the weight is currently set to Weight::max().

cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs

cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs

polkadot/xcm/pallet-xcm/src/benchmarking.rs

Co-authored-by: Branislav Kontur <bkontur@gmail.com>

github-actions · 2024-04-16T10:19:17Z

Review required! Latest push from author must always be reviewed

Szegoo · 2024-04-16T10:21:14Z

Would be great if we could get this merged soon :)

seadanda

Thanks!

Szegoo · 2024-05-05T14:22:30Z

Seems like we forgot to update the weights in this PR. I don't have the permission to run the bench bot so could someone run it and submit the changes in separate PR?

@seadanda @bkontur

bkontur · 2024-05-07T08:33:55Z

Seems like we forgot to update the weights in this PR. I don't have the permission to run the bench bot so could someone run it and submit the changes in separate PR?

@seadanda @bkontur

@Szegoo @seadanda waiting here: #4396 (comment)

Addressing comment: #3455 (comment) --------- Co-authored-by: command-bot <>

Addressing comment: paritytech#3455 (comment) --------- Co-authored-by: command-bot <>

The problem with the current implementation is that minting will cause the region coremask to be set to `Coremask::complete` regardless of the actual coremask. This PR fixes that. More details about the nonfungible implementation can be found here: #3455 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Addressing comment: paritytech#3455 (comment) --------- Co-authored-by: command-bot <>

The problem with the current implementation is that minting will cause the region coremask to be set to `Coremask::complete` regardless of the actual coremask. This PR fixes that. More details about the nonfungible implementation can be found here: paritytech#3455 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Szegoo and others added 6 commits February 23, 2024 10:50

Fix XCM benchmarks

5581f42

nonfungible implementation

89b8829

progress

55844cf

works

c398930

prdoc

9200399

Merge branch 'master' into xcm-bench

7f9eb12

Szegoo marked this pull request as ready for review February 23, 2024 16:27

Szegoo requested a review from a team as a code owner February 23, 2024 16:27

bkchr requested a review from bkontur February 24, 2024 15:28

Szegoo marked this pull request as draft February 27, 2024 08:57

Szegoo and others added 4 commits February 27, 2024 09:58

Merge branch 'master' into xcm-bench

99a447e

conflict readjustements

507eb47

fix

4b0ee5d

..

eb7a61b

Szegoo marked this pull request as ready for review February 27, 2024 12:49

Szegoo mentioned this pull request Feb 27, 2024

[pallet-xcm / pallet-xcm-benchmarks] Improvements #3470

Open

8 tasks

Szegoo and others added 6 commits March 2, 2024 17:16

Region reserve transfers

e1f99dd

tests & migration

01ffbe0

fix benchmarks

6307dd3

try runtmie

c9c2504

fix

2ebe29d

Merge branch 'master' into xcm-bench

beee619

bkontur reviewed Mar 5, 2024

View reviewed changes

Szegoo and others added 6 commits March 7, 2024 13:32

fix

5448324

Update cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs

911c8c2

Co-authored-by: Branislav Kontur <bkontur@gmail.com>

Update cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs

30a9133

Co-authored-by: Branislav Kontur <bkontur@gmail.com>

fix

8ec636b

check

7809eba

...

663dc0b

seadanda added T6-XCM This PR/Issue is related to XCM. T2-pallets This PR/Issue is related to a particular pallet. labels Apr 8, 2024

Szegoo added 2 commits April 8, 2024 17:50

Update substrate/frame/broker/src/lib.rs

e312286

Merge branch 'master' into xcm-bench

948aafa

github-actions bot requested a review from bkontur April 16, 2024 10:19

bkontur approved these changes Apr 16, 2024

View reviewed changes

seadanda approved these changes Apr 16, 2024

View reviewed changes

Szegoo added 2 commits April 16, 2024 17:28

add missing migration in rococo & westend

1374042

fmt

8d1d338

seadanda approved these changes Apr 17, 2024

View reviewed changes

seadanda added this pull request to the merge queue Apr 17, 2024

Merged via the queue into paritytech:master with commit e6f3106 Apr 17, 2024

bkontur mentioned this pull request May 7, 2024

Generate XCM weights for coretimes #4396

Merged

github-merge-queue bot pushed a commit that referenced this pull request May 7, 2024

Generate XCM weights for coretimes (#4396)

c91c13b

Addressing comment: #3455 (comment) --------- Co-authored-by: command-bot <>

paritytech-ci pushed a commit that referenced this pull request May 8, 2024

Generate XCM weights for coretimes (#4396)

f7c4f54

Addressing comment: #3455 (comment) --------- Co-authored-by: command-bot <>

hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024

Generate XCM weights for coretimes (paritytech#4396)

6855333

Addressing comment: paritytech#3455 (comment) --------- Co-authored-by: command-bot <>

Szegoo mentioned this pull request Jul 18, 2024

Fix region nonfungible implementation #5067

Merged

seadanda self-assigned this Jul 24, 2024

TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024

Generate XCM weights for coretimes (paritytech#4396)

f3beafe

Addressing comment: paritytech#3455 (comment) --------- Co-authored-by: command-bot <>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XCM coretime region transfers#3455

XCM coretime region transfers#3455
seadanda merged 46 commits intoparitytech:masterfrom
Szegoo:xcm-bench

Szegoo commented Feb 23, 2024 •

edited

Loading

Uh oh!

Szegoo commented Feb 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 16, 2024

Uh oh!

Szegoo commented Apr 16, 2024

Uh oh!

seadanda left a comment

Uh oh!

Szegoo commented May 5, 2024

Uh oh!

bkontur commented May 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Szegoo commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mint_into and burn implementation

Fixes made in this PR

Uh oh!

Szegoo commented Feb 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 16, 2024

Uh oh!

Szegoo commented Apr 16, 2024

Uh oh!

seadanda left a comment

Choose a reason for hiding this comment

Uh oh!

Szegoo commented May 5, 2024

Uh oh!

bkontur commented May 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Szegoo commented Feb 23, 2024 •

edited

Loading

`mint_into` and `burn` implementation