Skip to content

Remove usage of sp-std on templates#5001

Merged
bkchr merged 3 commits intoparitytech:masterfrom
jasl:remove-sp-std-for-templates
Jul 12, 2024
Merged

Remove usage of sp-std on templates#5001
bkchr merged 3 commits intoparitytech:masterfrom
jasl:remove-sp-std-for-templates

Conversation

@jasl
Copy link
Contributor

@jasl jasl commented Jul 11, 2024 •
edited
Loading

Following PR for #4941 that removes usage of sp-std on templates

sp-std crate was proposed to deprecate on #2101

@kianenigma

@jasl jasl mentioned this pull request Jul 11, 2024
Merged
1 task
@jasl jasl marked this pull request as draft July 11, 2024 10:33
@jasl jasl force-pushed the remove-sp-std-for-templates branch from 571f6fc to 484a074 Compare July 11, 2024 10:41
@jasl jasl marked this pull request as ready for review July 11, 2024 10:41
@jasl
Copy link
Contributor Author

jasl commented Jul 11, 2024

I see there much more sp-std usages on the mono-repo, will following another PR when I have time

kianenigma
kianenigma approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kianenigma kianenigma enabled auto-merge July 11, 2024 17:00
@jasl
Copy link
Contributor Author

jasl commented Jul 11, 2024

@kianenigma GHA shows Check PRdoc / check-prdoc (pull_request) fails.
This doesn't need a PRdoc right?

@jasl
Copy link
Contributor Author

jasl commented Jul 11, 2024

/bot fmt

auto-merge was automatically disabled July 11, 2024 17:07

Head branch was pushed to by a user without write access

@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Jul 11, 2024

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6679961

@bkchr bkchr added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Jul 11, 2024
@bkchr bkchr enabled auto-merge July 11, 2024 23:11
@bkchr bkchr added this pull request to the merge queue Jul 11, 2024
Merged via the queue into paritytech:master with commit 53598b8 Jul 12, 2024
@jasl jasl deleted the remove-sp-std-for-templates branch July 12, 2024 06:40
@jasl jasl mentioned this pull request Jul 12, 2024
Merged
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 13, 2024
@jasl @kianenigma @TomaszWaszczyk
Remove usage of sp-std on templates (paritytech#5001)
c2043dc 
Following PR for paritytech#4941
that removes usage of `sp-std` on templates

`sp-std` crate was proposed to deprecate on
paritytech#2101

@kianenigma

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
ordian added a commit that referenced this pull request Jul 15, 2024
@ordian
merge master and resolve conflicts
ce5de33 
* master: (120 commits)
  network/tx: Ban peers with tx that fail to decode (#5002)
  Try State Hook for Bounties (#4563)
  [statement-distribution] Add metrics for distributed statements in V2 (#4554)
  added sync command (#4818)
  Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935)
  xcm-executor: Improve logging (#4996)
  Remove usage of `sp-std` on templates (#5001)
  fixed cmd bot commenting not working (#5000)
  Explain usage of `<T: Config>` in FRAME storage + Update parachain pallet template  (#4941)
  Expose metadata-hash feature from polkadot crate (#4886)
  Add `MAX_INSTRUCTIONS_TO_DECODE` to XCMv2 (#4978)
  add notices to the implementer's guide docs that changed for elastic scaling (#4983)
  `polkadot-parachain` simplifications and deduplications (#4916)
  Update Templates README docs (#4980)
  allow clear_origin in safe xcm builder (#4777)
  litep2p/peerstore: Fix bump last updated time (#4971)
  Make `tracing::log` work in the runtime (#4863)
  sp-core: Improve docs generated by `generate_feature_enabled_macro` (#4968)
  [Backport] Version bumps  and  prdocs reordering from 1.14.0 (#4955)
  Assets: can_decrease/increase for destroying asset is not successful (#3286)
  ...
ordian added a commit that referenced this pull request Jul 18, 2024
@ordian
Merge branch 'master' into ao-fix-backing-filtering-on-disputes
f75dcd7 
* master: (125 commits)
  add elastic scaling MVP guide (#4663)
  Send PeerViewChange with high priority (#4755)
  [ci] Update forklift in CI image (#5032)
  Adjust base value for statement-distribution regression tests (#5028)
  [pallet_contracts] Add support for transient storage in contracts host functions (#4566)
  [1 / 5] Optimize logic for gossiping assignments (#4848)
  Remove `pallet-getter` usage from pallet-session (#4972)
  command-action: added scoped permissions to the github tokens (#5016)
  net/litep2p: Propagate ValuePut events to the network backend (#5018)
  rpc: add back rpc logger (#4952)
  Updated substrate-relay version for tests (#5017)
  Remove most all usage of `sp-std` (#5010)
  Use sp_runtime::traits::BadOrigin (#5011)
  network/tx: Ban peers with tx that fail to decode (#5002)
  Try State Hook for Bounties (#4563)
  [statement-distribution] Add metrics for distributed statements in V2 (#4554)
  added sync command (#4818)
  Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935)
  xcm-executor: Improve logging (#4996)
  Remove usage of `sp-std` on templates (#5001)
  ...
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@jasl @kianenigma @TarekkMA
Remove usage of sp-std on templates (paritytech#5001)
d08faa9 
Following PR for paritytech#4941
that removes usage of `sp-std` on templates

`sp-std` crate was proposed to deprecate on
paritytech#2101

@kianenigma

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
ordian added a commit that referenced this pull request Aug 6, 2024
@ordian
Merge branch 'master' into ao-account-for-enact-candidate-weight
e6978fd 
* master: (130 commits)
  add elastic scaling MVP guide (#4663)
  Send PeerViewChange with high priority (#4755)
  [ci] Update forklift in CI image (#5032)
  Adjust base value for statement-distribution regression tests (#5028)
  [pallet_contracts] Add support for transient storage in contracts host functions (#4566)
  [1 / 5] Optimize logic for gossiping assignments (#4848)
  Remove `pallet-getter` usage from pallet-session (#4972)
  command-action: added scoped permissions to the github tokens (#5016)
  net/litep2p: Propagate ValuePut events to the network backend (#5018)
  rpc: add back rpc logger (#4952)
  Updated substrate-relay version for tests (#5017)
  Remove most all usage of `sp-std` (#5010)
  Use sp_runtime::traits::BadOrigin (#5011)
  network/tx: Ban peers with tx that fail to decode (#5002)
  Try State Hook for Bounties (#4563)
  [statement-distribution] Add metrics for distributed statements in V2 (#4554)
  added sync command (#4818)
  Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935)
  xcm-executor: Improve logging (#4996)
  Remove usage of `sp-std` on templates (#5001)
  ...
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this pull request Dec 27, 2024
@jasl @kianenigma
Remove usage of sp-std on templates (paritytech#5001)
4013988 
Following PR for paritytech#4941
that removes usage of `sp-std` on templates

`sp-std` crate was proposed to deprecate on
paritytech#2101

@kianenigma

---------

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kianenigma kianenigma kianenigma approved these changes

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees

No one assigned

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasl @paritytech-cicd-pr @kianenigma @bkchr @ggwpez