Explain usage of `<T: Config>` in FRAME storage + Update parachain pallet template by kianenigma · Pull Request #4941 · paritytech/polkadot-sdk

kianenigma · 2024-07-04T10:17:43Z

Explains one of the annoying parts of FRAME storage that we have seen multiple times in PBA everyone gets stuck on.

I have not updated the other two templates for now, and only reflected it in the parachain template. That can happen in a follow-up.

Update possible answers in SE about the same topic.

Also we can't have the banner printed all the time, because it leads to printing malformed chain specs.

+ small fixes

+ addressing some nits

…n-omni-node

…-template

docs/sdk/src/reference_docs/frame_storage_derives.rs

ggwpez · 2024-07-05T14:33:07Z

substrate/frame/nis/src/lib.rs

 					.or_else(
-						|e| if e == TokenError::CannotCreate.into() { Ok(()) } else { Err(e) },
+						|e| {
+							if e == TokenError::CannotCreate.into() {


New formatter 🙈 ?

templates/minimal/README.md

templates/parachain/pallets/template/src/lib.rs

…aritytech/polkadot-sdk into kiz-update-tempalates-and-t-in-storage

kianenigma · 2024-07-10T12:18:12Z

bot fmt

command-bot · 2024-07-10T12:18:17Z

"$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" was queued.

Comment bot cancel 3-e454f776-9833-4266-a5ce-ae8e3eaf24f7 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-07-10T12:18:21Z

@kianenigma Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result:

Error: remote: HTTP Basic: Access denied. The provided password or token is incorrect or your account has 2FA enabled and you must use a personal access token instead of a password. See https://gitlab.parity.io/help/topics/git/troubleshooting_git#error-on-git-fetch-http-basic-access-denied
fatal: Authentication failed for 'https://gitlab.parity.io/parity/mirrors/polkadot-sdk.git/'
Error: remote: HTTP Basic: Access denied. The provided password or token is incorrect or your account has 2FA enabled and you must use a personal access token instead of a password. See https://gitlab.parity.io/help/topics/git/troubleshooting_git#error-on-git-fetch-http-basic-access-denied
fatal: Authentication failed for 'https://gitlab.parity.io/parity/mirrors/polkadot-sdk.git/'
    at ChildProcess.<anonymous> (/app/build/shell.js:73:39)
    at ChildProcess.emit (node:events:517:28)
    at ChildProcess.emit (node:domain:489:12)
    at maybeClose (node:internal/child_process:1098:16)
    at ChildProcess._handle.onexit (node:internal/child_process:303:5)

gpestana · 2024-07-10T15:29:59Z

templates/minimal/pallets/template/src/lib.rs

 //! A shell pallet built with [`frame`].
+//!
+//! To get started with this pallet, try implementing the guide in
+//! <https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/guides/your_first_pallet/index.html>


Suggested change

//! <https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/guides/your_first_pallet/index.html>

//! <https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/guides/your_first_pallet/index.html>.

jasl · 2024-07-10T17:48:44Z

templates/parachain/pallets/template/Cargo.toml


+# primitive deps
+sp-runtime = { workspace = true }
+sp-std = { workspace = true }


Was sp-std be proposed to soft deprecate?
#2101

hmm I see, a mistake indeed. Would you like to open a PR that reverts this + added a deprecation warning to sp-std, preventing this from happening?

I think I can make a following PR to remove the usage of sp-std here.
I don't know how to warn deprecation for a crate...

#5001
Following PR is here

@kianenigma

Following PR for #4941 that removes usage of `sp-std` on templates `sp-std` crate was proposed to deprecate on #2101 @kianenigma --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

…llet template (paritytech#4941) Explains one of the annoying parts of FRAME storage that we have seen multiple times in PBA everyone gets stuck on. I have not updated the other two templates for now, and only reflected it in the parachain template. That can happen in a follow-up. - [x] Update possible answers in SE about the same topic. --------- Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: command-bot <>

@kianenigma

Following PR for paritytech#4941 that removes usage of `sp-std` on templates `sp-std` crate was proposed to deprecate on paritytech#2101 @kianenigma --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* master: (120 commits) network/tx: Ban peers with tx that fail to decode (#5002) Try State Hook for Bounties (#4563) [statement-distribution] Add metrics for distributed statements in V2 (#4554) added sync command (#4818) Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935) xcm-executor: Improve logging (#4996) Remove usage of `sp-std` on templates (#5001) fixed cmd bot commenting not working (#5000) Explain usage of `<T: Config>` in FRAME storage + Update parachain pallet template (#4941) Expose metadata-hash feature from polkadot crate (#4886) Add `MAX_INSTRUCTIONS_TO_DECODE` to XCMv2 (#4978) add notices to the implementer's guide docs that changed for elastic scaling (#4983) `polkadot-parachain` simplifications and deduplications (#4916) Update Templates README docs (#4980) allow clear_origin in safe xcm builder (#4777) litep2p/peerstore: Fix bump last updated time (#4971) Make `tracing::log` work in the runtime (#4863) sp-core: Improve docs generated by `generate_feature_enabled_macro` (#4968) [Backport] Version bumps and prdocs reordering from 1.14.0 (#4955) Assets: can_decrease/increase for destroying asset is not successful (#3286) ...

…llet template (paritytech#4941) Explains one of the annoying parts of FRAME storage that we have seen multiple times in PBA everyone gets stuck on. I have not updated the other two templates for now, and only reflected it in the parachain template. That can happen in a follow-up. - [x] Update possible answers in SE about the same topic. --------- Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: command-bot <>

@kianenigma

Following PR for paritytech#4941 that removes usage of `sp-std` on templates `sp-std` crate was proposed to deprecate on paritytech#2101 @kianenigma --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

…llet template (paritytech#4941) Explains one of the annoying parts of FRAME storage that we have seen multiple times in PBA everyone gets stuck on. I have not updated the other two templates for now, and only reflected it in the parachain template. That can happen in a follow-up. - [x] Update possible answers in SE about the same topic. --------- Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: command-bot <>

@kianenigma

Following PR for paritytech#4941 that removes usage of `sp-std` on templates `sp-std` crate was proposed to deprecate on paritytech#2101 @kianenigma --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

kianenigma and others added 20 commits June 17, 2024 10:10

omni-node basics

df831b6

Fix --help commands

110f282

Also we can't have the banner printed all the time, because it leads to printing malformed chain specs.

--execution has no effect and a warning is printed

df08dba

Cosmetics

d2e8881

Remove unneeded Runtime variant

e0a3e1f

polkadot-parachain-omni-node v0.1.0

84b1d32

Remove manual testing chain specs

2c36b25

+ small fixes

Revert renaming

e766b02

+ addressing some nits

Avoid using hardcoded binary name

37cf6dd

Remove banner

52c3551

polkadot-parachain-bin

a796cd8

Cargo.lock

f758ade

Merge branch 'master' into polkadot-parachain-omni-node

819d06d

small fixes

db414bd

Merge remote-tracking branch 'upstream/master' into polkadot-parachai…

afee2dc

…n-omni-node

Remove more unneeded Runtime variants

df2a0a5

Fix typo

c19b29a

Merge branch 'master' of github.com:paritytech/polkadot-sdk

5ad5db6

Master.into()

ae5fecc

explain how to make FRAME storage generic over <T> + update in pallet…

d5a7084

…-template

kianenigma added R0-no-crate-publish-required The change does not require any crates to be re-published. T11-documentation This PR/Issue is related to documentation. labels Jul 4, 2024

kianenigma requested review from a team and cheme as code owners July 4, 2024 10:17

Merge branch 'master' into kiz-update-tempalates-and-t-in-storage

ce9f542

kianenigma changed the title ~~Kiz update tempalates and t in storage~~ Explain usage of <T: Config> in FRAME storage + Update parachain pallet template Jul 4, 2024

kianenigma added 2 commits July 5, 2024 11:55

fmt

bb45cd5

fix

79b25f6

kianenigma requested review from a team and koute as code owners July 5, 2024 08:59