Skip to content

Add pub to xcm::v4::PalletInfo #4976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggwpez merged 6 commits into from
Jul 18, 2024
Merged

Add pub to xcm::v4::PalletInfo #4976

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d322ce0
add `pub` to xcm::v4::PalletInfo
JuaniRios Jul 8, 2024
70e7ac6
Merge branch 'master' into pallet-info-pub
JuaniRios Jul 18, 2024
4e0f01d
prdoc
JuaniRios Jul 18, 2024
b793e17
Merge remote-tracking branch 'origin/pallet-info-pub' into pallet-inf…
JuaniRios Jul 18, 2024
d43cf39
Update prdoc/pr_4976.prdoc
acatangiu Jul 18, 2024
67bebb7
Merge branch 'master' into pallet-info-pub
acatangiu Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions polkadot/xcm/src/v4/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,15 +231,15 @@ parameter_types! {
#[derive(Clone, Eq, PartialEq, Encode, Decode, Debug, TypeInfo, MaxEncodedLen)]
pub struct PalletInfo {
#[codec(compact)]
index: u32,
name: BoundedVec<u8, MaxPalletNameLen>,
module_name: BoundedVec<u8, MaxPalletNameLen>,
pub index: u32,
pub name: BoundedVec<u8, MaxPalletNameLen>,
pub module_name: BoundedVec<u8, MaxPalletNameLen>,
#[codec(compact)]
major: u32,
pub major: u32,
#[codec(compact)]
minor: u32,
pub minor: u32,
#[codec(compact)]
patch: u32,
pub patch: u32,
}

impl TryInto<OldPalletInfo> for PalletInfo {
Expand Down
15 changes: 15 additions & 0 deletions prdoc/pr_4976.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: Add pub to xcm::v4::PalletInfo

doc:
- audience: Runtime Dev
description: |
Forgot to make v4 PalletInfo fields public. Without them we cannot make use of the struct.

crates:
- name: staging-xcm
bump: patch