Add pub to xcm::v4::PalletInfo#4976
Merged
ggwpez merged 6 commits intoparitytech:masterfrom Jul 18, 2024
Merged
Conversation
franciscoaguirre
approved these changes
Jul 8, 2024
Contributor
franciscoaguirre
left a comment
franciscoaguirre
left a comment
There was a problem hiding this comment.
This was clearly a misstep, let's backport it
acatangiu
approved these changes
Jul 8, 2024
Contributor
acatangiu
left a comment
acatangiu
left a comment
There was a problem hiding this comment.
Needs a prdoc (see directory called prdoc)
acatangiu
approved these changes
Jul 18, 2024
Contributor
Author
|
@acatangiu semver check failed because it thinks the change to pub is a major and not a patch. But the pub fields were the original API. Can we override the check? |
Contributor
Don't know honestly. @ggwpez @Morganamilo ? Changing this to |
ggwpez
approved these changes
Jul 18, 2024
Member
ggwpez
left a comment
ggwpez
left a comment
There was a problem hiding this comment.
CI seems to be wrong here - this does indeed not look like a major change to me.
Running the semver-check CLI locally confirms this.
ggwpez
reviewed
Jul 18, 2024
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
franciscoaguirre
pushed a commit
that referenced
this pull request
Jul 31, 2024
v3 PalletInfo had the fields public, but not v4. Any reason why? I need the PalletInfo fields public so I can read the values and do some logic based on that at Polimec @franciscoaguirre If this could be backported would be highly appreciated 🙏🏻 --------- Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
v3 PalletInfo had the fields public, but not v4. Any reason why? I need the PalletInfo fields public so I can read the values and do some logic based on that at Polimec @franciscoaguirre If this could be backported would be highly appreciated 🙏🏻 --------- Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Aug 15, 2024
Backporting #4976 to version 1.14.0. The fields in `PalletInfo` were not `pub` in XCMv4 when they were for XCMv3. --------- Co-authored-by: Juan Ignacio Rios <54085674+JuaniRios@users.noreply.github.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3 PalletInfo had the fields public, but not v4. Any reason why?
I need the PalletInfo fields public so I can read the values and do some logic based on that at Polimec
@franciscoaguirre
If this could be backported would be highly appreciated 🙏🏻