[xcm] runtime api for LocationToAccount conversions by bkontur · Pull Request #4857 · paritytech/polkadot-sdk

bkontur · 2024-06-21T12:42:03Z

Closes: #4298

This PR also merges xcm-fee-payment-runtime-api module to the xcm-runtime-api.

TODO

rename convert to convert_location and add new one convert_account (opposite direction)
add to the all testnet runtimes
check polkadot-js if supports that automatically or if needs to be added manually Add LocationToAccountApi::convert_location runtime API polkadot-js/api#5917
backport/patch for fellows and release (asap)

Open questions

should we merge xcm-runtime-api and xcm-fee-payment-runtime-api to the one module xcm-runtime-api ?

Usage

Input:

location: VersionedLocation

Output:

account_id bytes

acatangiu

Looks good!

should we merge xcm-runtime-api and xcm-fee-payment-runtime-api to the one module xcm-runtime-api ?

that sounds good hygiene to me, makes sense to have a structure like:

xcm-runtime-api
|    mod conversions
|    mod dry_run
|    mod fees

polkadot/xcm/xcm-runtime-api/tests/conversions.rs

polkadot/xcm/xcm-runtime-api/src/conversions.rs

Co-authored-by: Bastian Köcher <[email protected]>

Closes: paritytech#4298 This PR also merges `xcm-fee-payment-runtime-api` module to the `xcm-runtime-api`. ## TODO - [x] rename `convert` to `convert_location` and add new one `convert_account` (opposite direction) - [x] add to the all testnet runtimes - [x] check polkadot-js if supports that automatically or if needs to be added manually polkadot-js/api#5917 - [ ] backport/patch for fellows and release (asap) ## Open questions - [x] should we merge `xcm-runtime-api` and `xcm-fee-payment-runtime-api` to the one module `xcm-runtime-api` ? ## Usage Input: - `location: VersionedLocation` Output: - account_id bytes ![image](https://github.com/paritytech/polkadot-sdk/assets/8159517/4607b15a-77d2-462b-806c-606107776c0d) --------- Co-authored-by: Bastian Köcher <[email protected]> # Conflicts: # Cargo.lock # Cargo.toml # cumulus/parachains/integration-tests/emulated/chains/relays/westend/Cargo.toml # cumulus/parachains/integration-tests/emulated/tests/assets/asset-hub-westend/Cargo.toml # cumulus/parachains/runtimes/assets/asset-hub-rococo/Cargo.toml # cumulus/parachains/runtimes/assets/asset-hub-westend/Cargo.toml # cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/Cargo.toml # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/Cargo.toml # cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/lib.rs # cumulus/parachains/runtimes/collectives/collectives-westend/Cargo.toml # cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs # cumulus/parachains/runtimes/contracts/contracts-rococo/Cargo.toml # cumulus/parachains/runtimes/contracts/contracts-rococo/src/lib.rs # cumulus/parachains/runtimes/coretime/coretime-rococo/Cargo.toml # cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs # cumulus/parachains/runtimes/coretime/coretime-westend/Cargo.toml # cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs # cumulus/parachains/runtimes/people/people-rococo/Cargo.toml # cumulus/parachains/runtimes/people/people-rococo/src/lib.rs # cumulus/parachains/runtimes/people/people-westend/Cargo.toml # cumulus/parachains/runtimes/people/people-westend/src/lib.rs # cumulus/parachains/runtimes/testing/penpal/Cargo.toml # cumulus/parachains/runtimes/testing/penpal/src/lib.rs # cumulus/polkadot-parachain/Cargo.toml # polkadot/node/service/Cargo.toml # polkadot/runtime/rococo/Cargo.toml # polkadot/runtime/westend/Cargo.toml # polkadot/xcm/pallet-xcm/Cargo.toml # polkadot/xcm/xcm-runtime-apis/Cargo.toml # umbrella/Cargo.toml # umbrella/src/lib.rs

Closes: paritytech#4298 This PR also merges `xcm-fee-payment-runtime-api` module to the `xcm-runtime-api`. ## TODO - [x] rename `convert` to `convert_location` and add new one `convert_account` (opposite direction) - [x] add to the all testnet runtimes - [x] check polkadot-js if supports that automatically or if needs to be added manually polkadot-js/api#5917 - [ ] backport/patch for fellows and release (asap) ## Open questions - [x] should we merge `xcm-runtime-api` and `xcm-fee-payment-runtime-api` to the one module `xcm-runtime-api` ? ## Usage Input: - `location: VersionedLocation` Output: - account_id bytes ![image](https://github.com/paritytech/polkadot-sdk/assets/8159517/4607b15a-77d2-462b-806c-606107776c0d) --------- Co-authored-by: Bastian Köcher <[email protected]>

…imes (#413) Relates to: paritytech/polkadot-sdk#4298 Relates to: paritytech/polkadot-sdk#4857   - [ ] Does not require a CHANGELOG entry --------- Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: Dónal Murray <[email protected]>

Closes: paritytech#4298 This PR also merges `xcm-fee-payment-runtime-api` module to the `xcm-runtime-api`. ## TODO - [x] rename `convert` to `convert_location` and add new one `convert_account` (opposite direction) - [x] add to the all testnet runtimes - [x] check polkadot-js if supports that automatically or if needs to be added manually polkadot-js/api#5917 - [ ] backport/patch for fellows and release (asap) ## Open questions - [x] should we merge `xcm-runtime-api` and `xcm-fee-payment-runtime-api` to the one module `xcm-runtime-api` ? ## Usage Input: - `location: VersionedLocation` Output: - account_id bytes ![image](https://github.com/paritytech/polkadot-sdk/assets/8159517/4607b15a-77d2-462b-806c-606107776c0d) --------- Co-authored-by: Bastian Köcher <[email protected]>

## What? closes #446 **Tasks** * [x] Review [release notes for stable2412](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-stable2412) for breaking changes. Also check the release notes of the versions before (with a focus on `stable2409` and `1.14.0`). * [x] Update Polkadot SDK dependencies to `stable2412`. * [x] Update [ORML](https://github.com/open-web3-stack/open-runtime-module-library) dependencies to the according version. * [x] Test node and runtime compatibility (e.g., compile-time errors, runtime APIs, storage migrations). * [x] Audit custom pallets for deprecated or changed SDK interfaces. * [x] Update benchmarks (if applicable) for weight calculations. **Additional Context** * The `Treasury::propose_spend(...)` integrations tests needs a rework, since that extrinsic is now deprecated, and it should be replaced by `Treasury::sped_local(...)`. We can ignore these tests for now and re-add them in a later PR. ## Why? Release analysis posts [here](https://forum.polkadot.network/tag/release-analysis). Some notable PRs: - Replaces `SignedExtra` with new `TransactionExtension`. This requires us to reimplement the custom `CheckNonce` as a follow up PR - paritytech/polkadot-sdk#3685 - XCM V5 is now `latest`, so `v4` xcm types are replaced with `v5` - paritytech/polkadot-sdk#4826 - - merges `xcm-fee-payment-runtime-api` module into the new `xcm-runtime-apis` - paritytech/polkadot-sdk#4857 - remove `sp-std` dependency, replace with `alloc` or `core` ## How? ## Testing? * [x] Pallet Unit Testing (e.g. `cargo t -p pallet-funding`) * [x] Integration Tests (e.g. `cargo t -p integration-tests`) * [x] [Try Runtime CLI,](https://github.com/paritytech/try-runtime-cli) to test if we have to run any migration in this upgrade. ## Screenshots (optional) <details> <summary>Syncing with mainnet `polimec`</summary> <img width="1542" alt="Screenshot 2025-02-06 at 1 16 29" src="https://github.com/user-attachments/assets/7d14b32a-498f-4c4c-be5d-ccbda832d362" /> </details>

bkontur added 2 commits June 21, 2024 14:37

Initial implementation of LocationToAccountApi runtime API

374e427

Add it to the AssetHubWestend

87e231b

bkontur added the T6-XCM This PR/Issue is related to XCM. label Jun 21, 2024

BabakArtist approved these changes Jun 22, 2024

View reviewed changes

bkontur added 6 commits June 24, 2024 23:10

Nits

db24e91

Use xcm::VersionedLocation instead of xcm::latest::Location

5cdf57a

Added to the all testnets

36eedd5

Merge remote-tracking branch 'origin/master' into bko-xcm-runtime-api

c9684b3

Change to workspace deps

eb547b3

One more

098d1fb

bkontur mentioned this pull request Jun 25, 2024

Add LocationToAccountApi::convert_location runtime API polkadot-js/api#5917

Merged

bkontur added 3 commits June 25, 2024 10:21

taplo zepter

5eff80c

clippy imports

bd99b8d

prdoc

0a7b5de

bkontur mentioned this pull request Jun 25, 2024

Runtime API for LocationToAccountId Conversion #4298

Closed

bkontur added 2 commits June 25, 2024 10:58

Again import

208d24c

Fix umbrella

6d7b3fc

bkontur marked this pull request as ready for review June 25, 2024 09:16

bkontur requested a review from a team as a code owner June 25, 2024 09:16

bkontur added 2 commits June 25, 2024 11:44

Umbrella?

e4f5f0b

Merge branch 'master' into bko-xcm-runtime-api

de7147a

acatangiu approved these changes Jun 25, 2024

View reviewed changes

bkchr reviewed Jun 25, 2024

View reviewed changes

polkadot/xcm/xcm-runtime-api/tests/conversions.rs Outdated Show resolved Hide resolved

polkadot/xcm/xcm-runtime-api/src/conversions.rs Outdated Show resolved Hide resolved

polkadot/xcm/xcm-runtime-api/src/conversions.rs Show resolved Hide resolved

bkontur and others added 7 commits June 25, 2024 15:06

Update polkadot/xcm/xcm-runtime-api/tests/conversions.rs

e9da1da

Co-authored-by: Bastian Köcher <[email protected]>

Update polkadot/xcm/xcm-runtime-api/src/conversions.rs

fe41925

Co-authored-by: Bastian Köcher <[email protected]>

Merge branch 'master' into bko-xcm-runtime-api

b5d8faa

Simplify XCM runtime API

7b83b94

More cleaning

6f3a41c

Import

f695e7a

Merge xcm-fee-payment-runtime-api to xcm-runtime-api

ab63f0d

bkontur disabled auto-merge June 26, 2024 12:45

bkontur added 2 commits June 26, 2024 15:06

More review comments

540433c

Merge remote-tracking branch 'origin/master' into bko-xcm-runtime-api

6457a41

bkontur enabled auto-merge June 26, 2024 13:08

bkontur added this pull request to the merge queue Jun 26, 2024

Merged via the queue into master with commit 7506956 Jun 26, 2024

bkontur deleted the bko-xcm-runtime-api branch June 26, 2024 14:15

bkontur mentioned this pull request Jul 31, 2024

Add xcm_runtime_apis::conversions::LocationToAccountApi to all runtimes polkadot-fellows/runtimes#413

Merged

1 task

al3mart mentioned this pull request Aug 17, 2024

feat: Implement LocationToAccount runtime API r0gue-io/pop-node#210

Open

This was referenced Aug 21, 2024

Update polkadot-sdk from v1.11.0 to stable2407 moondance-labs/tanssi#659

Closed

Update polkadot-sdk from v1.11.0 to stable2407 moonbeam-foundation/moonbeam#2912

Closed

acatangiu assigned bkontur Sep 4, 2024

gonzamontiel mentioned this pull request Sep 4, 2024

Update moonbeam to polkadot stable2407 moonbeam-foundation/moonbeam#2932

Merged

Agusrodri mentioned this pull request Sep 27, 2024

Add XCM DryRun and LocationToAccount runtime APIs to all runtimes moonbeam-foundation/moonbeam#2980

Merged

TDemeco mentioned this pull request Oct 7, 2024

feat: ⏫ upgrade to Polkadot SDK v1.14.0 Moonsong-Labs/storage-hub#218

Merged

Roznovjak mentioned this pull request Dec 20, 2024

chore: upgrade to polkadot 2409 galacticcouncil/Basilisk-node#675

Merged

aurexav added a commit to darwinia-network/darwinia that referenced this pull request Dec 25, 2024

Companion of paritytech/polkadot-sdk#4857

6cac042

Roznovjak mentioned this pull request Jan 7, 2025

chore: upgrade to polkadot 2409 galacticcouncil/hydration-node#965

Merged

dastansam mentioned this pull request Feb 5, 2025

Upgrade to polkadot-stable2412-1 Polimec/polimec-node#448

Closed

9 tasks

dastansam mentioned this pull request Feb 26, 2025

Upgrade to stable2412-2 Polimec/polimec-node#462

Closed

9 tasks

dastansam mentioned this pull request Mar 14, 2025

⬆️ Upgrade to Polkadot SDK stable2412-2 Polimec/polimec-node#470

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[xcm] runtime api for LocationToAccount conversions#4857

[xcm] runtime api for LocationToAccount conversions#4857
bkontur merged 32 commits intomasterfrom
bko-xcm-runtime-api

bkontur commented Jun 21, 2024 •

edited

Loading

Uh oh!

acatangiu left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

bkontur commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Open questions

Usage

Uh oh!

acatangiu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bkontur commented Jun 21, 2024 •

edited

Loading