Upgrade to polkadot-stable2412-1

[dastansam]

What?

Work in progress upgrade to new stable version.

closes #446

Tasks

• Review release notes for stable2412 for breaking changes. Also check the release notes of the versions before (with a focus on stable2409 and 1.14.0).
• Update Polkadot SDK dependencies to stable2412.
• Update ORML dependencies to the according version.
• Test node and runtime compatibility (e.g., compile-time errors, runtime APIs, storage migrations).
• Audit custom pallets for deprecated or changed SDK interfaces.
• Update benchmarks (if applicable) for weight calculations.

Additional Context

• The Treasury::propose_spend(...) integrations tests needs a rework, since that extrinsic is now deprecated, and it should be replaced by Treasury::sped_local(...). We can ignore these tests for now and re-add them in a later PR.

Why?

Release analysis posts here.

Some notable PRs:

• Replaces SignedExtra with new TransactionExtension. This requires us to reimplement the custom CheckNonce as a follow up PR - FRAME: Reintroduce TransactionExtension as a replacement for SignedExtension paritytech/polkadot-sdk#3685
• XCM V5 is now latest, so v4 xcm types are replaced with v5 - XCM v5 paritytech/polkadot-sdk#4826 -
• merges xcm-fee-payment-runtime-api module into the new xcm-runtime-apis - [xcm] runtime api for LocationToAccount conversions paritytech/polkadot-sdk#4857

How?

Testing?

• Pallet Unit Testing (e.g. cargo t -p pallet-funding)
• Integration Tests (e.g. cargo t -p integration-tests)
• Try Runtime CLI, to test if we have to run any migration in this upgrade.

Screenshots (optional)

Syncing with mainnet `polimec`

`try-runtime` fails for `pallet-identity`

Anything Else?

• Due to the blockers listed in the issue above, currently orml crates are pointing to a fork
• Fixed some crates that are still not using workspace dependencies

Follow ups

• Fix integration tests errors
• Remove SignedExtension deprecation warnings, by replacing it with TxExtension
• Depend on crates.io versions for orml crates once new release is pushed
• Introduce pallet-migrations for multi block migrations support. pallet_identity::V1ToV2 migrations is a lazy migration which needs pallet-migrations (see 2 in screenshots)

[graphite-app]

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (02/05/25)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

[dastansam]

copied from ApproveOrigin above

[dastansam]

should probably be bumped to system_version: 2 (?)

[dastansam]

should be reviewed as well

[dastansam]

tried adding pallet-migrations and identity migration there, but try-runtime is failing:

[2025-02-07T16:48:05Z ERROR pallet_migrations] Ongoing migrations interrupted - chain stuck
[2025-02-07T16:48:05Z ERROR runtime] panicked at .cargo/registry/src/index.crates.io-6f17d22bba15001f/pallet-migrations-9.0.0/src/lib.rs:813:13:
    Migration with index Some(0) failed.
[2025-02-07T16:48:05Z ERROR try_runtime_core::commands::on_runtime_upgrade] ❌ Migrations are not idempotent, they failed during the second execution.

will need to investigate whether this is from migration or sth wrong with the pallet

[lrazovic]

ORML 1.3.0 is out and should work now without problem with stable2412-1! https://github.com/open-web3-stack/open-runtime-module-library/releases/tag/v1.3.0

I'll investigate further the migrations problem.

[dastansam]

working on an upgrade to stable2412-2 instead

ORML 1.3.0 is out and should work now without problem with stable2412-1! https://github.com/open-web3-stack/open-runtime-module-library/releases/tag/v1.3.0

I'll investigate further the migrations problem.

[dastansam]

closed in favour of #462