Add omni bencher & chain-spec-builder bins to release by EgorPopelyaev · Pull Request #4557 · paritytech/polkadot-sdk

EgorPopelyaev · 2024-05-23T14:57:40Z

Closes: #4354

This PR adds the steps to build and attach frame-omni-bencher and chain-spec-builder binaries to the release draft

TODO

add also chain-spec-builder binary
~~check/investigate Kian's comment: chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate~~ see comment
Backport to [email protected] release, so we can use it for next fellows release: Short benchmarking in CI with frame-omni-bencher + extract chain-spec-builder stuff to get_preset polkadot-fellows/runtimes#324
Backport to [email protected] release

bkontur · 2024-05-24T08:12:34Z

@kianenigma
Do we need here this rlib?

[lib]
crate-type = ["rlib"]

Co-authored-by: Branislav Kontur <[email protected]>

paritytech-cicd-pr · 2024-05-24T14:25:32Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6285730

EgorPopelyaev · 2024-05-27T08:51:06Z

@kianenigma @bkontur guys, the flow is working now and both bins can be built and attached to the release.
Regarding the check that the version of the chain-spec-builder should match the sp-genesis-builder, not sure what to do with that, should be done here as part of the pipeline?

…nto epo-add-omni-bencher-bin-to-release

kianenigma · 2024-05-28T06:08:41Z

@kianenigma Do we need here this rlib?
[lib]
crate-type = ["rlib"]

I don't think so, but I am also not the original author of the crate to know why it was there to begin with. From what I read about the definition of rlib, it can be removed. Is it causing issues with the release?

bkontur · 2024-05-28T09:23:54Z

@kianenigma Do we need here this rlib?
[lib]
crate-type = ["rlib"]
I don't think so, but I am also not the original author of the crate to know why it was there to begin with. From what I read about the definition of rlib, it can be removed. Is it causing issues with the release?

@kianenigma no, there is no problem, it just caught my attention, and we don' use it elsewhere except two binaries: polkadot-cli and staging-node-cli

and to the same versioning for those two crates, please continue discussions here: #4518 (comment)

pavelsupr

Everything is OK in this specific commit for me, but the initial release file contained a binary dependency (L. 76) from a single developer without pinning/checks of the integrity of it. IMO it should be localised or replaced.

Closes: #4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](#4518 (comment)) - [ ] Backport to `[email protected]` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `[email protected]` release --------- Co-authored-by: Branislav Kontur <[email protected]>

marking it as release-able, attaching the same version number that is attached to other binaries such as `polkadot` and `polkadot-parachain`. I have more thoughts about the version number, though. The chain-spec builder is mainly a user of the `sp-genesis-builder` api. So the versioning should be such that it helps users know give a version of `sp-genesis-builder` in their runtime, which version of `chain-spec-builder` should they use? With this, we can possibly alter the version number to always match `sp-genesis-builder`. Fixes #4352 - [x] Add to release artifacts ~~similar to #4405 done here: #4557 --------- Co-authored-by: Branislav Kontur <[email protected]>

* master: (93 commits) Fix broken windows build (#4636) Beefy client generic on aduthority Id (#1816) pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620) Broker new price adapter (#4521) Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621) Update README.md (#4623) Publish `chain-spec-builder` (#4518) Add omni bencher & chain-spec-builder bins to release (#4557) Moves runtime macro out of experimental flag (#4249) Filter workspace dependencies in the templates (#4599) parachain-inherent: Make `para_id` more prominent (#4555) Add metric to measure the time it takes to gather enough assignments (#4587) Improve On_demand_assigner events (#4339) Conditional `required` checks (#4544) [CI] Deny adding git deps (#4572) [subsytem-bench] Remove redundant banchmark_name param (#4540) Add availability-recovery from systematic chunks (#1644) Remove workspace lints from templates (#4598) `sc-chain-spec`: deprecated code removed (#4410) [subsystem-benchmarks] Add statement-distribution benchmarks (#3863) ...

Closes: paritytech#4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](paritytech#4518 (comment)) - [ ] Backport to `[email protected]` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `[email protected]` release --------- Co-authored-by: Branislav Kontur <[email protected]>

marking it as release-able, attaching the same version number that is attached to other binaries such as `polkadot` and `polkadot-parachain`. I have more thoughts about the version number, though. The chain-spec builder is mainly a user of the `sp-genesis-builder` api. So the versioning should be such that it helps users know give a version of `sp-genesis-builder` in their runtime, which version of `chain-spec-builder` should they use? With this, we can possibly alter the version number to always match `sp-genesis-builder`. Fixes paritytech#4352 - [x] Add to release artifacts ~~similar to paritytech#4405 done here: paritytech#4557 --------- Co-authored-by: Branislav Kontur <[email protected]>

Closes: paritytech#4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](paritytech#4518 (comment)) - [ ] Backport to `[email protected]` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `[email protected]` release --------- Co-authored-by: Branislav Kontur <[email protected]>

marking it as release-able, attaching the same version number that is attached to other binaries such as `polkadot` and `polkadot-parachain`. I have more thoughts about the version number, though. The chain-spec builder is mainly a user of the `sp-genesis-builder` api. So the versioning should be such that it helps users know give a version of `sp-genesis-builder` in their runtime, which version of `chain-spec-builder` should they use? With this, we can possibly alter the version number to always match `sp-genesis-builder`. Fixes paritytech#4352 - [x] Add to release artifacts ~~similar to paritytech#4405 done here: paritytech#4557 --------- Co-authored-by: Branislav Kontur <[email protected]>

Closes: paritytech#4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](paritytech#4518 (comment)) - [ ] Backport to `[email protected]` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `[email protected]` release --------- Co-authored-by: Branislav Kontur <[email protected]>

marking it as release-able, attaching the same version number that is attached to other binaries such as `polkadot` and `polkadot-parachain`. I have more thoughts about the version number, though. The chain-spec builder is mainly a user of the `sp-genesis-builder` api. So the versioning should be such that it helps users know give a version of `sp-genesis-builder` in their runtime, which version of `chain-spec-builder` should they use? With this, we can possibly alter the version number to always match `sp-genesis-builder`. Fixes paritytech#4352 - [x] Add to release artifacts ~~similar to paritytech#4405 done here: paritytech#4557 --------- Co-authored-by: Branislav Kontur <[email protected]>

EgorPopelyaev added 3 commits May 23, 2024 15:52

add build and upload omni-bencher binary steps

cb98666

don't wait for omni-bencher in rumtimes publishing

366b7f9

fix typo in the path

cd60027

EgorPopelyaev added the R0-no-crate-publish-required The change does not require any crates to be re-published. label May 23, 2024

EgorPopelyaev requested review from bkontur and kianenigma May 23, 2024 14:57

EgorPopelyaev added 5 commits May 23, 2024 18:24

add download omni-bencher artifact

6c120df

test extended path to binary

b1b74bc

adjust path to the bin artifact

51441ec

adjust path once again

c935181

make name of the upload binary step generic

a10197a

bkontur reviewed May 24, 2024

View reviewed changes

Comment thread .github/workflows/release-30_publish_release_draft.yml Outdated

bkontur reviewed May 24, 2024

View reviewed changes

Comment thread .github/workflows/release-30_publish_release_draft.yml Outdated

EgorPopelyaev changed the title ~~Add omni bencher bin to release~~ Add omni bencher & chain-spec-builder bins to release May 24, 2024

EgorPopelyaev and others added 2 commits May 24, 2024 12:10

use production profile

771a366

Co-authored-by: Branislav Kontur <[email protected]>

use production profile

e449ac0

Co-authored-by: Branislav Kontur <[email protected]>

bkontur mentioned this pull request May 24, 2024

Publish chain-spec-builder #4518

Merged

1 task

EgorPopelyaev added 4 commits May 24, 2024 14:47

add chain-spec-builder to release

bbf0100

test uplaod bins

c5950e9

test

2d965e3

test

387af96

EgorPopelyaev added 4 commits May 24, 2024 16:29

one more test

6ede5bf

reorg flow

683e1d3

reorg tools installation

f171a3c

build bins separately

7aa822d

EgorPopelyaev marked this pull request as ready for review May 27, 2024 08:47

EgorPopelyaev requested review from a team as code owners May 27, 2024 08:47

Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…

ba6b6ba

…nto epo-add-omni-bencher-bin-to-release

bkontur approved these changes May 28, 2024

View reviewed changes

AndWeHaveAPlan approved these changes May 28, 2024

View reviewed changes

alvicsam approved these changes May 28, 2024

View reviewed changes

EgorPopelyaev requested a review from pavelsupr May 28, 2024 10:14

pavelsupr approved these changes May 28, 2024

View reviewed changes

kianenigma approved these changes May 29, 2024

View reviewed changes

EgorPopelyaev added this pull request to the merge queue May 29, 2024

Merged via the queue into paritytech:master with commit 89604da May 29, 2024

EgorPopelyaev deleted the epo-add-omni-bencher-bin-to-release branch May 29, 2024 06:12

bkontur mentioned this pull request May 29, 2024

CI short benchmarking with frame-omni-bencher #4405

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add omni bencher & chain-spec-builder bins to release#4557

Add omni bencher & chain-spec-builder bins to release#4557
EgorPopelyaev merged 19 commits intoparitytech:masterfrom
EgorPopelyaev:epo-add-omni-bencher-bin-to-release

EgorPopelyaev commented May 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

bkontur commented May 24, 2024

Uh oh!

paritytech-cicd-pr commented May 24, 2024

Uh oh!

EgorPopelyaev commented May 27, 2024

Uh oh!

kianenigma commented May 28, 2024

Uh oh!

bkontur commented May 28, 2024

Uh oh!

pavelsupr left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

EgorPopelyaev commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

Uh oh!

Uh oh!

bkontur commented May 24, 2024

Uh oh!

paritytech-cicd-pr commented May 24, 2024

Uh oh!

EgorPopelyaev commented May 27, 2024

Uh oh!

kianenigma commented May 28, 2024

Uh oh!

bkontur commented May 28, 2024

Uh oh!

pavelsupr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

EgorPopelyaev commented May 23, 2024 •

edited

Loading