Publish `chain-spec-builder` by kianenigma · Pull Request #4518 · paritytech/polkadot-sdk

kianenigma · 2024-05-20T09:35:07Z

marking it as release-able, attaching the same version number that is attached to other binaries such as polkadot and polkadot-parachain.

I have more thoughts about the version number, though. The chain-spec builder is mainly a user of the sp-genesis-builder api. So the versioning should be such that it helps users know give a version of sp-genesis-builder in their runtime, which version of chain-spec-builder should they use?

With this, we can possibly alter the version number to always match sp-genesis-builder.

Fixes #4352

Add to release artifacts ~~similar to CI short benchmarking with frame-omni-bencher #4405~~ done here: Add omni bencher & chain-spec-builder bins to release #4557

kianenigma · 2024-05-21T08:57:13Z

@michalkucharczyk do you have further ideas about the version number to be used here?

michalkucharczyk · 2024-05-21T09:01:54Z

@michalkucharczyk do you have further ideas about the version number to be used here?

What you proposed is fine for me.

bkontur · 2024-05-24T10:20:03Z

I updated the description, release artifacts are done here: #4557

paritytech-cicd-pr · 2024-05-28T07:20:24Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6319025

bkontur · 2024-05-28T09:16:54Z

I think we can merge this.

@kianenigma
And to the same/aligned versioning for sp-genesis-builder and staging-chain-spec-builder, afaiu, it does not make sense to do any version toml magic/checks in the master branch, because we don't care about [package.version] in the master branch,
e.g. pallet-balances in the master has 28.0.0 but actual release version is 35.0.0. Also sp-genesis-builder has 0.8.0 in the master and latest creates.io release has 0.13.0.

But for every published release we have e.g. release-crates-io-v1.12.0/Plan.toml which is probably generated by parity-publish tool, so I think that this tool is responsible for correct versions uploaded to the crates.io.

Thus, I think that this tool or release process to crates.io should take care about keeping the same version for the modules: sp-genesis-builder and staging-chain-spec-builder.

@Morganamilo wdyt?

kianenigma · 2024-05-29T03:18:15Z

@bkontur Thanks for the detailed explanation.

afaiu, it does not make sense to do any version toml magic/checks in the master branch, because we don't care about [package.version] in the master branch,

My understanding is that this is a temporary state and we will eventually move to a system where the versions in master or more or less representative of reality. But someone from the release task force should confirm this (@liamaharon @ggwpez)

In either case, I am happy to merge this even if the version sync is not perfect yet. But, if my assumption above is not correct, please make an issue such that we can the end goal.

Also, @michalkucharczyk do you foresee any further breaking changes to the runtime apis? if not, I am over-thinking all of this :D

Closes: #4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](#4518 (comment)) - [ ] Backport to `polkadot-sdk@1.11` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `polkadot-sdk@1.12` release --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>

bkontur · 2024-05-29T08:32:25Z

In either case, I am happy to merge this even if the version sync is not perfect yet. But, if my assumption above is not correct, please make an issue such that we can the end goal.

@kianenigma @ggwpez @liamaharon @Morganamilo @michalkucharczyk please, continue discussion here: #4626

bkontur · 2024-05-29T08:40:01Z

@EgorPopelyaev @Morganamilo
guys, when this is merged, we need to:

1. yank or remove actual 0.0.0 version: https://crates.io/crates/staging-chain-spec-builder/versions
2. backport this PR to the release-crates-io-v1.12.0
release staging-chain-spec-builder as a version 1.13.0
3. backport this PR to the release-crates-io-v1.11.0
release staging-chain-spec-builder as a version 1.12.0
4. close the issue: release chain-spec-builder #4352

marking it as release-able, attaching the same version number that is attached to other binaries such as `polkadot` and `polkadot-parachain`. I have more thoughts about the version number, though. The chain-spec builder is mainly a user of the `sp-genesis-builder` api. So the versioning should be such that it helps users know give a version of `sp-genesis-builder` in their runtime, which version of `chain-spec-builder` should they use? With this, we can possibly alter the version number to always match `sp-genesis-builder`. Fixes #4352 - [x] Add to release artifacts ~~similar to #4405 done here: #4557 --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>

* master: (93 commits) Fix broken windows build (#4636) Beefy client generic on aduthority Id (#1816) pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620) Broker new price adapter (#4521) Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621) Update README.md (#4623) Publish `chain-spec-builder` (#4518) Add omni bencher & chain-spec-builder bins to release (#4557) Moves runtime macro out of experimental flag (#4249) Filter workspace dependencies in the templates (#4599) parachain-inherent: Make `para_id` more prominent (#4555) Add metric to measure the time it takes to gather enough assignments (#4587) Improve On_demand_assigner events (#4339) Conditional `required` checks (#4544) [CI] Deny adding git deps (#4572) [subsytem-bench] Remove redundant banchmark_name param (#4540) Add availability-recovery from systematic chunks (#1644) Remove workspace lints from templates (#4598) `sc-chain-spec`: deprecated code removed (#4410) [subsystem-benchmarks] Add statement-distribution benchmarks (#3863) ...

Closes: paritytech#4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](paritytech#4518 (comment)) - [ ] Backport to `polkadot-sdk@1.11` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `polkadot-sdk@1.12` release --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>

marking it as release-able, attaching the same version number that is attached to other binaries such as `polkadot` and `polkadot-parachain`. I have more thoughts about the version number, though. The chain-spec builder is mainly a user of the `sp-genesis-builder` api. So the versioning should be such that it helps users know give a version of `sp-genesis-builder` in their runtime, which version of `chain-spec-builder` should they use? With this, we can possibly alter the version number to always match `sp-genesis-builder`. Fixes paritytech#4352 - [x] Add to release artifacts ~~similar to paritytech#4405 done here: paritytech#4557 --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>

Closes: paritytech#4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](paritytech#4518 (comment)) - [ ] Backport to `polkadot-sdk@1.11` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `polkadot-sdk@1.12` release --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>

marking it as release-able, attaching the same version number that is attached to other binaries such as `polkadot` and `polkadot-parachain`. I have more thoughts about the version number, though. The chain-spec builder is mainly a user of the `sp-genesis-builder` api. So the versioning should be such that it helps users know give a version of `sp-genesis-builder` in their runtime, which version of `chain-spec-builder` should they use? With this, we can possibly alter the version number to always match `sp-genesis-builder`. Fixes paritytech#4352 - [x] Add to release artifacts ~~similar to paritytech#4405 done here: paritytech#4557 --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>

Closes: paritytech#4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](paritytech#4518 (comment)) - [ ] Backport to `polkadot-sdk@1.11` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `polkadot-sdk@1.12` release --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>

marking it as release-able, attaching the same version number that is attached to other binaries such as `polkadot` and `polkadot-parachain`. I have more thoughts about the version number, though. The chain-spec builder is mainly a user of the `sp-genesis-builder` api. So the versioning should be such that it helps users know give a version of `sp-genesis-builder` in their runtime, which version of `chain-spec-builder` should they use? With this, we can possibly alter the version number to always match `sp-genesis-builder`. Fixes paritytech#4352 - [x] Add to release artifacts ~~similar to paritytech#4405 done here: paritytech#4557 --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>

kianenigma added 2 commits May 20, 2024 10:30

Publish chain-spec-builder

4365cc3

fix

06690d4

kianenigma added the R0-no-crate-publish-required The change does not require any crates to be re-published. label May 20, 2024

add description

c3fc9fc

bkchr approved these changes May 20, 2024

View reviewed changes

gupnik approved these changes May 21, 2024

View reviewed changes

michalkucharczyk approved these changes May 21, 2024

View reviewed changes

bkontur approved these changes May 24, 2024

View reviewed changes

Merge branch 'master' into kiz-publish-chain-spec

698d185

bkontur added 2 commits May 28, 2024 10:58

Merge remote-tracking branch 'origin/master' into kiz-publish-chain-spec

129a84a

Updated Cargo.lock

eac6c0f

bkontur mentioned this pull request May 28, 2024

Add omni bencher & chain-spec-builder bins to release #4557

Merged

4 tasks

Merge branch 'master' into kiz-publish-chain-spec

981a49a

bkontur mentioned this pull request May 29, 2024

Ability to maintain multiple crates with the same/synchronized version #4626

Open

bkontur added this pull request to the merge queue May 29, 2024

Merged via the queue into master with commit dfcfa4a May 29, 2024

bkontur deleted the kiz-publish-chain-spec branch May 29, 2024 08:56

bkontur mentioned this pull request Jul 23, 2024

Remove chain-spec-generator polkadot-fellows/runtimes#395

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish `chain-spec-builder`#4518

Publish `chain-spec-builder`#4518
bkontur merged 7 commits intomasterfrom
kiz-publish-chain-spec

kianenigma commented May 20, 2024 •

edited by bkontur

Loading

Uh oh!

kianenigma commented May 21, 2024

Uh oh!

michalkucharczyk commented May 21, 2024

Uh oh!

bkontur commented May 24, 2024

Uh oh!

paritytech-cicd-pr commented May 28, 2024

Uh oh!

bkontur commented May 28, 2024

Uh oh!

kianenigma commented May 29, 2024

Uh oh!

bkontur commented May 29, 2024

Uh oh!

bkontur commented May 29, 2024 •

edited by EgorPopelyaev

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

kianenigma commented May 20, 2024 • edited by bkontur Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kianenigma commented May 21, 2024

Uh oh!

michalkucharczyk commented May 21, 2024

Uh oh!

bkontur commented May 24, 2024

Uh oh!

paritytech-cicd-pr commented May 28, 2024

Uh oh!

bkontur commented May 28, 2024

Uh oh!

kianenigma commented May 29, 2024

Uh oh!

bkontur commented May 29, 2024

Uh oh!

bkontur commented May 29, 2024 • edited by EgorPopelyaev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kianenigma commented May 20, 2024 •

edited by bkontur

Loading

bkontur commented May 29, 2024 •

edited by EgorPopelyaev

Loading