Skip to content

Add generate and verify logic for AncestryProof#4430

Merged
serban300 merged 3 commits intoparitytech:masterfrom
serban300:beefy-equivocation-runtime
May 13, 2024
Merged

Add generate and verify logic for AncestryProof#4430
serban300 merged 3 commits intoparitytech:masterfrom
serban300:beefy-equivocation-runtime

Conversation

@serban300
Copy link
Contributor

Extracting the logic for generating and verifying ancestry proofs from this PR: #1903 with small adjustments

@Lederstrumpf I added you as a co-author to each commit. Please let me know if you want me to also associate an e-mail address with your name

@serban300 serban300 requested a review from a team May 10, 2024 15:14
@serban300 serban300 self-assigned this May 10, 2024
@serban300 serban300 requested a review from acatangiu as a code owner May 10, 2024 15:14
@serban300 serban300 changed the title Add generate and verify logic for AncestryProof Add generate and verify logic for AncestryProof May 10, 2024
@serban300 serban300 added R0-no-crate-publish-required The change does not require any crates to be re-published. T15-bridges This PR/Issue is related to bridges. labels May 10, 2024
@acatangiu acatangiu requested a review from svyatonik May 13, 2024 07:42
@serban300 serban300 added this pull request to the merge queue May 13, 2024
Merged via the queue into paritytech:master with commit f4b73bd May 13, 2024
@serban300 serban300 deleted the beefy-equivocation-runtime branch May 13, 2024 09:04
ordian added a commit that referenced this pull request May 14, 2024
* master:
  improve MockValidationDataInherentDataProvider to support async backing (#4442)
  Bump `proc-macro-crate` to the latest version (#4409)
  [ci] Run check-runtime-migration in GHA (#4441)
  prospective-parachains rework (#4035)
  [ci] Add forklift to GHA ARC (#4372)
  `CheckWeight` SE: Check for extrinsic length + proof size combined (#4326)
  Add generate and verify logic for `AncestryProof` (#4430)
  Rococo AH: undeploy trie migration (#4414)
  Remove `substrate-frame-cli` (#4403)
  migrations: `take()`should consume read and write operation weight (#4302)
  `remote-externalities`: store block header in snapshot (#4349)
  xcm-emlator: Use `BlockNumberFor` instead of `parachains_common::BlockNumber=u32` (#4434)
  Remove `pallet::getter` usage from authority-discovery pallet (#4091)
  Remove pallet::getter usage from pallet-contracts-mock-network (#4417)
  Add docs to request_core_count (#4423)
Lederstrumpf added a commit to Lederstrumpf/polkadot-sdk that referenced this pull request May 20, 2024
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
Extracting the logic for generating and verifying ancestry proofs from
this PR: paritytech#1903 with small
adjustments

@Lederstrumpf I added you as a co-author to each commit. Please let me
know if you want me to also associate an e-mail address with your name
@ggwpez
Copy link
Member

ggwpez commented Jun 11, 2024

Not R0-silent either. It breaks peoples runtimes when they try to update (like Polkadot and Kusama).

Im just going to assume that i can replace Proof with LeafProof as there is no info on what to do.

@ggwpez ggwpez removed the R0-no-crate-publish-required The change does not require any crates to be re-published. label Jun 11, 2024
@serban300
Copy link
Contributor Author

Not R0-silent either. It breaks peoples runtimes when they try to update (like Polkadot and Kusama).

Sorry, I didn't realize. I thought that non-functional changes are R0-silent

Im just going to assume that i can replace Proof with LeafProof as there is no info on what to do.

Yes, that's all.

liuchengxu pushed a commit to liuchengxu/polkadot-sdk that referenced this pull request Jun 19, 2024
Extracting the logic for generating and verifying ancestry proofs from
this PR: paritytech#1903 with small
adjustments

@Lederstrumpf I added you as a co-author to each commit. Please let me
know if you want me to also associate an e-mail address with your name
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Extracting the logic for generating and verifying ancestry proofs from
this PR: paritytech#1903 with small
adjustments

@Lederstrumpf I added you as a co-author to each commit. Please let me
know if you want me to also associate an e-mail address with your name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T15-bridges This PR/Issue is related to bridges.

Projects

Status: Audited

Development

Successfully merging this pull request may close these issues.

4 participants