Remove pallet::getter usage from authority-discovery pallet - #4091
Conversation
|
User @PolkadotDom, please sign the CLA here. |
…-pallet-authority-discovery
|
Review required! Latest push from author must always be reviewed |
|
@liamaharon resolved the previous comment if you have a second for re-review |
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
|
Realized I need to implement getters for the storage values since they were previously public. Hold on review for the moment. |
|
@PolkadotDom I did not know they were public, good catch. when you introduce them, these changes wont be breaking anymore, you can change bump to minor |
Sounds good! 👍 |
…-pallet-authority-discovery
|
@muharem Actually, it looks like there was a bit of a redundancy. The pallet previously had both macro generated getters as well as explicit getters. So instead of implementing new ones for the lost macros I'm just going to keep the bump major and update the prdoc to reflect that the explicit getters should be used moving forward. Let me know if you think it should be otherwise. |
* master: improve MockValidationDataInherentDataProvider to support async backing (#4442) Bump `proc-macro-crate` to the latest version (#4409) [ci] Run check-runtime-migration in GHA (#4441) prospective-parachains rework (#4035) [ci] Add forklift to GHA ARC (#4372) `CheckWeight` SE: Check for extrinsic length + proof size combined (#4326) Add generate and verify logic for `AncestryProof` (#4430) Rococo AH: undeploy trie migration (#4414) Remove `substrate-frame-cli` (#4403) migrations: `take()`should consume read and write operation weight (#4302) `remote-externalities`: store block header in snapshot (#4349) xcm-emlator: Use `BlockNumberFor` instead of `parachains_common::BlockNumber=u32` (#4434) Remove `pallet::getter` usage from authority-discovery pallet (#4091) Remove pallet::getter usage from pallet-contracts-mock-network (#4417) Add docs to request_core_count (#4423)
5 participants
As per #3326, removes pallet::getter usage from the pallet authority-discovery. The syntax
StorageItem::<T, I>::get()should be used instead.cc @muraca