Contracts: Test benchmarking v2 by pgherveou · Pull Request #3585 · paritytech/polkadot-sdk

pgherveou · 2024-03-05T20:22:24Z

No description provided.

pgherveou · 2024-03-05T21:24:36Z

bot help

command-bot · 2024-03-05T21:24:41Z

Here's a link to docs

pgherveou · 2024-03-05T21:25:26Z

bot bench substrate-pallet --pallet=pallet_contracts

command-bot · 2024-03-05T21:25:31Z

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5445625 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-0446b041-b1a8-4f4b-a230-4d824b7329bb to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-03-05T23:01:45Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5445625 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5445625/artifacts/download.

athei

Nice work :)

substrate/frame/contracts/src/benchmarking/mod.rs

pgherveou · 2024-03-06T11:57:39Z

Depends on #3574

substrate/frame/contracts/src/benchmarking/mod.rs

pgherveou · 2024-03-07T10:01:21Z

🔒 for now some of the generated pov are much larger
@ggwpez is working on adding pov_mode = measured

https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=10&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=proof&old=master&new=pg%2Fcontracts-benchmark-v2

waiting for #3616

paritytech-cicd-pr · 2024-03-08T17:32:47Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5476947

pgherveou · 2024-03-08T19:42:30Z

bot bench substrate-pallet --pallet=pallet_contracts

command-bot · 2024-03-08T19:42:34Z

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5478214 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-e6ea78a8-dda6-4eac-91d8-5750dc7f822a to cancel this command or bot cancel to cancel all commands in this pull request.

…=dev --target_dir=substrate --pallet=pallet_contracts

command-bot · 2024-03-08T21:16:31Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5478214 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5478214/artifacts/download.

pgherveou · 2024-03-19T13:43:55Z

bot bench substrate-pallet --pallet=pallet_contracts

command-bot · 2024-03-19T13:44:01Z

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5570268 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-d361e1ec-da03-43f0-81aa-21302df10bfa to cancel this command or bot cancel to cancel all commands in this pull request.

…=dev --target_dir=substrate --pallet=pallet_contracts

command-bot · 2024-03-19T15:19:29Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5570268 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5570268/artifacts/download.

pgherveou · 2024-03-19T16:16:21Z

bot bench substrate-pallet --pallet=pallet_contracts

command-bot · 2024-03-19T16:16:27Z

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5573329 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-9aa4ef8e-609e-4ba7-abf4-404d656e148a to cancel this command or bot cancel to cancel all commands in this pull request.

…nto HEAD

…=dev --target_dir=substrate --pallet=pallet_contracts

command-bot · 2024-03-19T17:51:27Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5573329 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5573329/artifacts/download.

Co-authored-by: command-bot <>

pgherveou requested a review from athei as a code owner March 5, 2024 20:22

pgherveou changed the title ~~Test benchmarking v2~~ Contracts: Test benchmarking v2 Mar 5, 2024

pgherveou added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Mar 5, 2024

athei reviewed Mar 6, 2024

View reviewed changes

substrate/frame/contracts/src/benchmarking/mod.rs Outdated Show resolved Hide resolved

athei approved these changes Mar 6, 2024

View reviewed changes

pgherveou commented Mar 6, 2024

View reviewed changes

substrate/frame/contracts/src/benchmarking/mod.rs Outdated Show resolved Hide resolved

pgherveou mentioned this pull request Mar 7, 2024

Contracts: Fix terminate benchmark #3558

Merged

pgherveou changed the base branch from master to oty-bench-v2-pov-mode March 8, 2024 17:20

pgherveou force-pushed the pg/contracts-benchmark-v2 branch from 1fe29d0 to f6b1036 Compare March 8, 2024 17:21

pgherveou requested a review from a team as a code owner March 8, 2024 17:21

wip

a6a0407

pgherveou force-pushed the pg/contracts-benchmark-v2 branch from f6b1036 to a6a0407 Compare March 8, 2024 17:27

pgherveou changed the base branch from oty-bench-v2-pov-mode to master March 8, 2024 17:27

cherry picking changes from oliver's branch

012ad7a

pgherveou added 3 commits March 8, 2024 18:33

fix

86f57b5

fix

8e6bbeb

Merge branch 'master' into pg/contracts-benchmark-v2

00c8e42

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

fe5c722

…=dev --target_dir=substrate --pallet=pallet_contracts

Merge branch 'master' into pg/contracts-benchmark-v2

50657b8

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

9b3c4a3

…=dev --target_dir=substrate --pallet=pallet_contracts

fix missing

57355f7

command-bot added 2 commits March 19, 2024 16:18

Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…

dbdb1d4

…nto HEAD

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

1941bc1

…=dev --target_dir=substrate --pallet=pallet_contracts

xermicus approved these changes Mar 19, 2024

View reviewed changes

pgherveou added this pull request to the merge queue Mar 19, 2024

Merged via the queue into master with commit e659c4b Mar 19, 2024

pgherveou deleted the pg/contracts-benchmark-v2 branch March 19, 2024 19:39

dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Mar 24, 2024

Contracts: Test benchmarking v2 (paritytech#3585)

ccaac29

Co-authored-by: command-bot <>

Conversation

pgherveou commented Mar 5, 2024

Uh oh!

pgherveou commented Mar 5, 2024

Uh oh!

command-bot bot commented Mar 5, 2024

Uh oh!

pgherveou commented Mar 5, 2024

Uh oh!

command-bot bot commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 5, 2024

Uh oh!

athei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pgherveou commented Mar 6, 2024

Uh oh!

Uh oh!

pgherveou commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paritytech-cicd-pr commented Mar 8, 2024

Uh oh!

pgherveou commented Mar 8, 2024

Uh oh!

command-bot bot commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 8, 2024

Uh oh!

pgherveou commented Mar 19, 2024

Uh oh!

command-bot bot commented Mar 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 19, 2024

Uh oh!

pgherveou commented Mar 19, 2024

Uh oh!

command-bot bot commented Mar 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

command-bot bot commented Mar 5, 2024 •

edited

Loading

pgherveou commented Mar 7, 2024 •

edited

Loading

command-bot bot commented Mar 8, 2024 •

edited

Loading

command-bot bot commented Mar 19, 2024 •

edited

Loading

command-bot bot commented Mar 19, 2024 •

edited

Loading