Contracts: Fix terminate benchmark

[pgherveou]

No description provided.

[pgherveou]

We could also introduce a seal_terminate_per_locked_dependency but the extra PoV should be pretty low and will be refunded anyway with PoV Reclaim

[athei]

Let's wait for the benchmarks to see how bad it is. I don't think the reclaim is working, yet. The linked PR is only the node side. However, terminate is rare enough so that I wouldn't optimize too much for it so we are probably good.

[athei]

Let's wait for the benchmarks to see how bad it is. I don't think the reclaim is working, yet. The linked PR is only the node side. However, terminate is rare enough so that I wouldn't optimize too much for it so we are probably good.

[pgherveou]

bot bench substrate-pallet --pallet=pallet_contracts

[command-bot]

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5445920 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-b08d8bbb-009c-4b41-8094-21932a8ead5e to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5445920 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5445920/artifacts/download.

[pgherveou]

Weights are much higher (194%) as expected

Since this is a rare operation and PoV refund is around the corner (runtime PR merged here do you think it's still worth adding a terminate_per_locked_delegate_dependency?

[athei]

I think then it is fine to just use the worst case here.

[pgherveou]

🔒 for now some of the generated pov are much larger
https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=10&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=proof&old=master&new=pg%2Fcontracts-benchmark-v2

[athei]

Weird. Those should not have been affected by your changes here?

[pgherveou]

Weird. Those should not have been affected by your changes here?

oups:sorry this is a comment for #3585