Snowbridge - Test pallet order#3381
Merged
bkontur merged 25 commits intoparitytech:masterfrom Feb 21, 2024
Merged
Conversation
* pallet order * fmt * adds test for bridge order * revert unintended change --------- Co-authored-by: claravanstaden <Cats 4 life!>
# Conflicts: # polkadot/node/subsystem-bench/src/approval/mod.rs # polkadot/node/subsystem-bench/src/availability/mod.rs # polkadot/node/subsystem-bench/src/cli.rs # polkadot/node/subsystem-bench/src/core/environment.rs # polkadot/node/subsystem-bench/src/subsystem-bench.rs
…to snowbridge-test-pallet-order
Contributor
Author
bkontur
added
the
R0-no-crate-publish-required
bkontur
reviewed
Feb 20, 2024
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/tests/snowbridge.rs
Outdated
Show resolved
Hide resolved
added 2 commits
February 20, 2024 19:44
…to snowbridge-test-pallet-order
acatangiu
approved these changes
Feb 21, 2024
| #[cfg(feature = "runtime-benchmarks")] | ||
| use benchmark_helpers::DoNothingRouter; | ||
| #[cfg(not(feature = "runtime-benchmarks"))] | ||
| //#[cfg(not(feature = "runtime-benchmarks"))] |
claravanstaden
commented
Feb 21, 2024
Comment on lines
-370
to
-373
| #[cfg(feature = "runtime-benchmarks")] | ||
| type MessageProcessor = | ||
| pallet_message_queue::mock_helpers::NoopMessageProcessor<AggregateMessageOrigin>; | ||
| #[cfg(not(feature = "runtime-benchmarks"))] |
Contributor
Author
There was a problem hiding this comment.
@bkontur the problem with the benchmark tests lies here. If the NoopMessageProcessor is used, the messages aren't actually processed and so the nonces doesn't increment and all the post-message sending checks fail. It looks like the tests pass with the without the special NoopMessageProcessor, will double check CI.
# Conflicts: # cumulus/parachains/runtimes/assets/test-utils/src/test_cases_over_bridge.rs
bkontur
approved these changes
Feb 21, 2024
Contributor
bkontur
left a comment
bkontur
left a comment
There was a problem hiding this comment.
you can revert that benchmark stuff: #3381 (comment)
and fix it as a separate
added 2 commits
February 21, 2024 13:43
…to snowbridge-test-pallet-order
auto-merge was automatically disabled
February 21, 2024 11:44
Head branch was pushed to by a user without write access
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_to_block_with_finalizeto simulate the block finalizing. The existingrun_to_blockmethod does not finalize and so it cannot successfully test this condition.Closes: #3208