Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## snowbridge #112 +/- ##
=============================================
Coverage ? 40.50%
=============================================
Files ? 51
Lines ? 3335
Branches ? 0
=============================================
Hits ? 1351
Misses ? 1984
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alistair-singh
left a comment
alistair-singh
left a comment
There was a problem hiding this comment.
Just some comments to help my understanding of the test. But looks good.
| let mut found_outbound_digest = false; | ||
| for digest_item in digest_items { | ||
| match digest_item { | ||
| DigestItem::Other(_) => found_outbound_digest = true, |
There was a problem hiding this comment.
So we assert that the message is queued on a block and then the DigestItem exists in the next block. This test asserts that the pallet order is correct?
There was a problem hiding this comment.
Yes, so if the pallet order is incorrect (i.e. the MessageQueue pallet is before the EthereumOutboundQueue pallet in the construct_runtime macro), our message digest won't be found. I tested this locally, works nicely.
4 participants
Adds a test to verify that the Ethereum Outbound Queue digest is in contained in a block.
I used @yrong's PR https://github.com/Snowfork/snowbridge/pull/1126/files to use the pallet order to finalize the blocks. I verified if I change the runtime pallet order so that the MessageQueue pallet is before the EthereumOutboundQueue pallet, the test fails.