ci: bump ci image to rust 1.73.0 by altaua · Pull Request #1830 · paritytech/polkadot-sdk

altaua · 2023-10-09T15:15:53Z

No description provided.

altaua · 2023-10-10T20:40:05Z

bot update-ui -v CMD_IMAGE=paritytech/ci-unified:bullseye-1.73.0-2023-05-23-v20231009

command-bot · 2023-10-10T20:40:10Z

@altaua https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929179 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 21-d64c5649-a04f-4694-b994-73d77eabec62 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-10T20:59:03Z

@altaua Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929179 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929179/artifacts/download.

altaua · 2023-10-10T22:33:58Z

bot fmt

command-bot · 2023-10-10T22:34:03Z

@altaua https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929467 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 22-7c29411d-8ff3-48bf-b8e7-36fb80c068ac to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-10-10T22:36:22Z

@altaua Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929467 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3929467/artifacts/download.

kianenigma · 2023-10-11T10:42:57Z

substrate/client/network/src/protocol/notifications/behaviour.rs

 									let delay_id = self.next_delay_id;
 									self.next_delay_id.0 += 1;
 									let delay = futures_timer::Delay::new(ban_duration);
-									let peer_id = peer_id;


wonder why these were here before?

it used to be let peer_id = *peer_id; until this commit, which just removed the * and left the remaining no-op line around.

.cargo/config.toml

bitflags 1.3 won't be updated to avoid triggering the bad-bit-macro check, it really is time to update to bitflags 2.

rustc warns about noop calls to `clone` now. These cases here look like just passing through the original reference is the right thing.

This avoids glob ambiguity that the compiler will no longer allow in future releases.

ggwpez · 2023-10-11T16:08:06Z

Can you also check if its worth to update the Rust version that the bot fmt uses please?
Currently we are on nightly-2023-05-16.

altaua · 2023-10-11T16:24:32Z

Can you also check if its worth to update the Rust version that the bot fmt uses please? Currently we are on nightly-2023-05-16.

yeah that's on the todo list too, nightly bumps are always a huge hassle though

* master: (33 commits) ci: set CI_IMAGE back to (now updated) .ci-unified (#1854) ci: bump ci image to rust 1.73.0 (#1830) Refactor Identity to benchmark v2 (#1838) PVF worker: bump landlock, update ABI docs (#1850) Xcm emulator nits (#1649) Fixes path issue in derive-impl (#1823) upgrade to macro_magic 0.4.3 (#1832) Use safe math when pruning statuses (#1835) remote-ext: fix state download stall on slow connections and reduce memory usage (#1295) Update testnet bootnode dns name (#1712) [FRAME] Warn on unchecked weight witness (#1818) [xcm] Use `Weight::MAX` for `reserve_asset_deposited`, `receive_teleported_asset` benchmarks (#1726) Update bridges subtree (#1803) Check for parent of first ready block being on chain (#1812) Make CheckNonce refuse transactions signed by accounts with no providers (#1578) Fix Asset Hub collator crashing when starting from genesis (#1788) Mixnet integration (#1346) [xcm-emulator] Decouple the `AccountId` type from `AccountId32` (#1458) Treasury spends various asset kinds (#1333) chore: bump zombienter version (#1806) ...

Co-authored-by: command-bot <>

altaua added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-no-crate-publish-required The change does not require any crates to be re-published. labels Oct 9, 2023

altaua self-assigned this Oct 9, 2023

altaua force-pushed the mira/rust-1.73 branch 3 times, most recently from 16a5b68 to 3591975 Compare October 10, 2023 20:35

paritytech deleted a comment from command-bot bot Oct 10, 2023

altaua force-pushed the mira/rust-1.73 branch from dd5e962 to 1ccbda5 Compare October 10, 2023 21:43

altaua marked this pull request as ready for review October 10, 2023 22:39

altaua requested a review from athei as a code owner October 10, 2023 22:39

altaua requested a review from a team October 10, 2023 22:40

altaua requested a review from jsidorenko as a code owner October 10, 2023 22:40

altaua requested a review from a team October 10, 2023 22:40

altaua requested review from a team and koute as code owners October 10, 2023 22:40

paritytech-ci requested a review from a team October 10, 2023 22:41

alvicsam approved these changes Oct 11, 2023

View reviewed changes

sergejparity approved these changes Oct 11, 2023

View reviewed changes

kianenigma approved these changes Oct 11, 2023

View reviewed changes

altaua force-pushed the mira/rust-1.73 branch from 31657d3 to f925f9d Compare October 11, 2023 10:54

liamaharon approved these changes Oct 11, 2023

View reviewed changes

ggwpez reviewed Oct 11, 2023

View reviewed changes

.cargo/config.toml Outdated Show resolved Hide resolved

altaua force-pushed the mira/rust-1.73 branch from f925f9d to 916c6cd Compare October 11, 2023 13:24

altaua force-pushed the mira/rust-1.73 branch from 916c6cd to b7f3816 Compare October 11, 2023 14:53

ggwpez approved these changes Oct 11, 2023

View reviewed changes

Mira Ressel and others added 6 commits October 11, 2023 17:27

ci: bump ci image to rust 1.73.0

bdb5aef

chore: apply new clippy 1.73 suggestions

b400a45

bitflags 1.3 won't be updated to avoid triggering the bad-bit-macro check, it really is time to update to bitflags 2.

fix: Drop noop clone calls

6c37738

rustc warns about noop calls to `clone` now. These cases here look like just passing through the original reference is the right thing.

chore(frame/nfts): explicitly import crate::SystemConfig

988ffb4

This avoids glob ambiguity that the compiler will no longer allow in future releases.

chore: update ui tests for rust 1.73.0

f3bd5c3

".git/.scripts/commands/fmt/fmt.sh"

8f4d0f6

altaua force-pushed the mira/rust-1.73 branch 2 times, most recently from 023a9e8 to 8333105 Compare October 11, 2023 15:50

chore: disable rustdoc::redundant_explicit_links warning

0f6eebc

altaua force-pushed the mira/rust-1.73 branch from 8333105 to 0f6eebc Compare October 11, 2023 16:58

altaua requested a review from a team October 11, 2023 16:58

altaua merged commit 447e753 into master Oct 11, 2023

altaua deleted the mira/rust-1.73 branch October 11, 2023 17:50

acatangiu pushed a commit to acatangiu/polkadot-sdk that referenced this pull request Oct 31, 2023

ci: bump ci image to rust 1.73.0 (paritytech#1830)

8842a5c

Co-authored-by: command-bot <>

kiltbot mentioned this pull request Nov 7, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.2.0 to 1.3.0 KILTprotocol/kilt-node#575

Closed

bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024

ci: bump ci image to rust 1.73.0 (paritytech#1830)

e3ac3a3

Co-authored-by: command-bot <>

bkchr pushed a commit that referenced this pull request Apr 10, 2024

bump bridge hub versions (#1830)

63308ac

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: bump ci image to rust 1.73.0#1830

ci: bump ci image to rust 1.73.0#1830
altaua merged 7 commits intomasterfrom
mira/rust-1.73

altaua commented Oct 9, 2023

Uh oh!

altaua commented Oct 10, 2023

Uh oh!

command-bot bot commented Oct 10, 2023 •

edited

Loading

Uh oh!

command-bot bot commented Oct 10, 2023

Uh oh!

altaua commented Oct 10, 2023

Uh oh!

command-bot bot commented Oct 10, 2023 •

edited

Loading

Uh oh!

command-bot bot commented Oct 10, 2023

Uh oh!

kianenigma Oct 11, 2023

Uh oh!

altaua Oct 11, 2023

Uh oh!

Uh oh!

ggwpez commented Oct 11, 2023

Uh oh!

altaua commented Oct 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

altaua commented Oct 9, 2023

Uh oh!

altaua commented Oct 10, 2023

Uh oh!

command-bot bot commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Oct 10, 2023

Uh oh!

altaua commented Oct 10, 2023

Uh oh!

command-bot bot commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Oct 10, 2023

Uh oh!

kianenigma Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

altaua Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ggwpez commented Oct 11, 2023

Uh oh!

altaua commented Oct 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

command-bot bot commented Oct 10, 2023 •

edited

Loading

command-bot bot commented Oct 10, 2023 •

edited

Loading