Make CheckNonce refuse transactions signed by accounts with no providers#1578
Merged
bkchr merged 2 commits intoparitytech:masterfrom Oct 10, 2023
Merged
Conversation
3d637c3 to
a54a5ff
Compare
ggwpez
approved these changes
Oct 4, 2023
a54a5ff to
aca2eba
Compare
aca2eba to
7589baa
Compare
zdave-parity
commented
Oct 5, 2023
| number, | ||
| state_root, | ||
| extrinsics_root, | ||
| state_root: Default::default(), |
Contributor
Author
There was a problem hiding this comment.
AIUI state_root and extrinsics_root are not used by Core_initialize_block and should just be set to 0 here.
zdave-parity
commented
Oct 5, 2023
| ), | ||
| vec![Transfer { | ||
| from: AccountKeyring::Alice.into(), | ||
| from: AccountKeyring::One.into(), |
Contributor
Author
There was a problem hiding this comment.
Alice has no balance in the genesis state. As this test runtime has no transaction fees I think this was just resulting in the transaction failing. With the CheckNonce change the transaction was invalid and causing the runtime to panic.
Contributor
|
This will make #1725 harder |
Member
ordian
added a commit
that referenced
this pull request
Oct 12, 2023
* master: (33 commits) ci: set CI_IMAGE back to (now updated) .ci-unified (#1854) ci: bump ci image to rust 1.73.0 (#1830) Refactor Identity to benchmark v2 (#1838) PVF worker: bump landlock, update ABI docs (#1850) Xcm emulator nits (#1649) Fixes path issue in derive-impl (#1823) upgrade to macro_magic 0.4.3 (#1832) Use safe math when pruning statuses (#1835) remote-ext: fix state download stall on slow connections and reduce memory usage (#1295) Update testnet bootnode dns name (#1712) [FRAME] Warn on unchecked weight witness (#1818) [xcm] Use `Weight::MAX` for `reserve_asset_deposited`, `receive_teleported_asset` benchmarks (#1726) Update bridges subtree (#1803) Check for parent of first ready block being on chain (#1812) Make CheckNonce refuse transactions signed by accounts with no providers (#1578) Fix Asset Hub collator crashing when starting from genesis (#1788) Mixnet integration (#1346) [xcm-emulator] Decouple the `AccountId` type from `AccountId32` (#1458) Treasury spends various asset kinds (#1333) chore: bump zombienter version (#1806) ...
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v1-3-0/4614/1 |
CertainLach
added a commit
to UniqueNetwork/pallet-sponsoring
that referenced
this pull request
Nov 21, 2023
Broken in upstream in paritytech/polkadot-sdk#1578
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
…ers (paritytech#1578) See paritytech#1453. Co-authored-by: Bastian Köcher <git@kchr.de>
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* do not wait for tx status forever * more logging
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1453.