Skip to content

[xcm-emulator] Restructure Parachains Integration Tests #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bkontur wants to merge 1 commit into from
Closed

[xcm-emulator] Restructure Parachains Integration Tests #1693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .../parachains/integration-tests/emulated/assets/asset-hub-kusama/src/tests/hrmp_channels.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ use crate::*;
const MAX_CAPACITY: u32 = 8;
const MAX_MESSAGE_SIZE: u32 = 8192;

// TODO: does not test anything relevant to AssetHub (uses just Kuama and Penpals) - move to Kusama
// tests
/// Opening HRMP channels between Parachains should work
#[test]
fn open_hrmp_channel_between_paras_works() {
Expand Down Expand Up @@ -157,6 +159,8 @@ fn force_open_hrmp_channel_for_system_para_works() {
// Parachain A init values
let para_a_id = PenpalKusamaA::para_id();

// TODO: try PenpalKusamaA::send(AssetHubKusama) -> XcmpQueue should fail Unroutable?

Kusama::execute_with(|| {
assert_ok!(<Kusama as KusamaPallet>::Hrmp::force_open_hrmp_channel(
relay_root_origin,
Expand Down Expand Up @@ -187,4 +191,8 @@ fn force_open_hrmp_channel_for_system_para_works() {
});

Kusama::force_process_hrmp_open(system_para_id, para_a_id);

// TODO: try PenpalKusamaA::send(AssetHubKusama) -> should pass on PenpalKusamaA
// TODO: assert call result on AssetHubKusama
// TODO: or join this test with `send_xcm_from_para_to_system_para_paying_fee_with_assets_works`
}
1 change: 1 addition & 0 deletions cumulus/parachains/integration-tests/emulated/assets/asset-hub-kusama/src/tests/send.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ fn send_transact_as_superuser_from_relay_to_system_para_works() {
super::do_force_create_asset_from_relay_to_system_para(OriginKind::Superuser);
}

// TODO: should go to the runtime as unit-test directly, not needed in emulator tests
/// System Parachain shouldn't be able to execute `Transact` instructions in Relay Chain
/// when `OriginKind::Native`
#[test]
Expand Down
2 changes: 2 additions & 0 deletions ...rachains/integration-tests/emulated/assets/asset-hub-kusama/src/tests/set_xcm_versions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

use crate::*;

// TODO: does not test anything relevant to AssetHub (AssetHubKusama::para_id() can be changed for
// whatever para_id) - move to Kusama tests or directly to the Kusama runtime as unit-test
#[test]
fn relay_sets_system_para_xcm_supported_version() {
// Init tests variables
Expand Down
8 changes: 8 additions & 0 deletions ...arachains/integration-tests/emulated/assets/asset-hub-polkadot/src/tests/hrmp_channels.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ use crate::*;
const MAX_CAPACITY: u32 = 8;
const MAX_MESSAGE_SIZE: u32 = 8192;

// TODO: does not test anything relevant to AssetHub (uses just Kuama and Penpals) - move to Kusama
// tests
/// Opening HRMP channels between Parachains should work
#[test]
fn open_hrmp_channel_between_paras_works() {
Expand Down Expand Up @@ -157,6 +159,8 @@ fn force_open_hrmp_channel_for_system_para_works() {
// Parachain A init values
let para_a_id = PenpalPolkadotA::para_id();

// TODO: try PenpalPolkadotA::send(AssetHubPolkadot) -> XcmpQueue should fail Unroutable?

Polkadot::execute_with(|| {
assert_ok!(<Polkadot as PolkadotPallet>::Hrmp::force_open_hrmp_channel(
relay_root_origin,
Expand Down Expand Up @@ -187,4 +191,8 @@ fn force_open_hrmp_channel_for_system_para_works() {
});

Polkadot::force_process_hrmp_open(system_para_id, para_a_id);

// TODO: try PenpalKusamaA::send(AssetHubKusama) -> should pass on PenpalKusamaA
// TODO: assert call result on AssetHubKusama
// TODO: or join this test with `send_xcm_from_para_to_system_para_paying_fee_with_assets_works`
}
1 change: 1 addition & 0 deletions cumulus/parachains/integration-tests/emulated/assets/asset-hub-polkadot/src/tests/send.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ fn send_transact_as_superuser_from_relay_to_system_para_works() {
super::do_force_create_asset_from_relay_to_system_para(OriginKind::Superuser);
}

// TODO: should go to the runtime as unit-test directly, not needed in emulator tests
/// System Parachain shouldn't be able to execute `Transact` instructions in Relay Chain
/// when `OriginKind::Native`
#[test]
Expand Down
2 changes: 2 additions & 0 deletions ...chains/integration-tests/emulated/assets/asset-hub-polkadot/src/tests/set_xcm_versions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

use crate::*;

// TODO: does not test anything relevant to AssetHub (AssetHubPolkadot::para_id() can be changed for
// whatever para_id) - move to Polkadot tests or directly to the Polkadot runtime as unit-test
#[test]
fn relay_sets_system_para_xcm_supported_version() {
// Init tests variables
Expand Down
2 changes: 2 additions & 0 deletions ...achains/integration-tests/emulated/assets/asset-hub-westend/src/tests/set_xcm_versions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

use crate::*;

// TODO: does not test anything relevant to AssetHub (AssetHubWestend::para_id() can be changed for
// whatever para_id) - move to Westend tests or directly to the Westend runtime as unit-test
#[test]
fn relay_sets_system_para_xcm_supported_version() {
// Init tests variables
Expand Down