[xcm-emulator] Restructure Parachains Integration Tests#1693
Closed
bkontur wants to merge 1 commit intobko-xcm-emulator-nitsfrom
Closed
[xcm-emulator] Restructure Parachains Integration Tests#1693bkontur wants to merge 1 commit intobko-xcm-emulator-nitsfrom
bkontur wants to merge 1 commit intobko-xcm-emulator-nitsfrom
Conversation
This was referenced Sep 25, 2023
Merged
bkontur
added
T9-cumulus
Contributor
Author
|
closing, integration tests will be moved out and fixed elsewhere |
bkontur
added a commit
that referenced
this pull request
Oct 11, 2023
# Desription ## Summary This PR introduces several nits and tweaks to xcm emulator tests for system parachains. ## Explanation **Deduplicate `XcmPallet::send(` with root origin code** - Introduced `send_transact_to_parachain` which could be easily reuse for scenarios like _governance call from relay chain to parachain_. **Refactor `send_transact_sudo_from_relay_to_system_para_works`** - Test covered just one use-case which was moved to the `do_force_create_asset_from_relay_to_system_para`, so now we can extend this test with more _governance-like_ senarios. - Renamed to `send_transact_as_superuser_from_relay_to_system_para_works`. **Remove `send_transact_native_from_relay_to_system_para_fails` test** - This test and/or description is kind of misleading, because system paras support Native from relay chain by `RelayChainAsNative` with correct xcm origin. - It tested only sending on relay chain which should go directly to the relay chain unit-tests (does not even need to be in xcm emulator level). ## Future directions Check restructure parachains integration tests [issue](#1389) and [PR with more TODOs](#1693). --------- Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com>
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* removed MintReward and added PayLaneRewardFromAccount * clippy * added issue ref to TODO
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1389
Closes #1389
TODO