Skip to content

bump rlp-derive version #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ordian merged 2 commits into from
Sep 11, 2024
Merged

bump rlp-derive version #861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeaacc3
bump rlp-derive version
ordian Sep 11, 2024
5be22d3
fix rlp version
ordian Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rlp-derive/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "rlp-derive"
version = "0.1.0"
version = "0.2.0"
Copy link
Copy Markdown
Contributor

@niklasad1 niklasad1 Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why breaking change in the derive crate but not in the rlp?

Copy link
Copy Markdown
Contributor

@niklasad1 niklasad1 Sep 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it was MSRV bump but probably applies to rlp as well because it depends on rlp-derive?!

Copy link
Copy Markdown
Contributor Author

@ordian ordian Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a breaking change for rlp as well. I've accidentally published rlp 0.6.0 with rlp-derive versioned at 0.1.0 and then yanked that version. So it will go from 0.5.2 to 0.6.1 (already published).

Copy link
Copy Markdown
Contributor

@niklasad1 niklasad1 Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, cool missed that

authors = ["Parity Technologies <[email protected]>"]
license = "MIT OR Apache-2.0"
description = "Derive macro for #[derive(RlpEncodable, RlpDecodable)]"
Expand Down
3 changes: 2 additions & 1 deletion rlp/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ The format is based on [Keep a Changelog].

[Keep a Changelog]: http://keepachangelog.com/en/1.0.0/

## [0.6.0] - 2024-09-11
## [0.6.1] - 2024-09-11
- Migrated to 2021 edition, enforcing MSRV of `1.56.1`. [#601](https://github.com/paritytech/parity-common/pull/601)
- Updated `rlp` to 0.2.0. [#860](https://github.com/paritytech/parity-common/pull/860)

## [0.5.2] - 2022-10-21
- Add optional `derive` feature. [#613](https://github.com/paritytech/parity-common/pull/613)
Expand Down
4 changes: 2 additions & 2 deletions rlp/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "rlp"
version = "0.6.0"
version = "0.6.1"
description = "Recursive-length prefix encoding, decoding, and compression"
repository = "https://github.com/paritytech/parity-common"
license = "MIT OR Apache-2.0"
Expand All @@ -11,7 +11,7 @@ rust-version = "1.56.1"
[dependencies]
bytes = { version = "1", default-features = false }
rustc-hex = { version = "2.0.1", default-features = false }
rlp-derive = { version = "0.1", path = "../rlp-derive", optional = true }
rlp-derive = { version = "0.2", path = "../rlp-derive", optional = true }

[dev-dependencies]
criterion = "0.5.1"
Expand Down