Skip to content

Rialto parachain <> Millau messages bridge#1218

Merged
svyatonik merged 1 commit intomasterfrom
rialto-parachain-millau-messages-bridge
May 20, 2022
Merged

Rialto parachain <> Millau messages bridge#1218
svyatonik merged 1 commit intomasterfrom
rialto-parachain-millau-messages-bridge

Conversation

@svyatonik
Copy link
Copy Markdown
Contributor

@svyatonik svyatonik commented Nov 19, 2021

on top of #1199
closes #884

In progress - I just want to take a break && do a little work on code deduplication mostly in relayer (though runtime integration also may be improved a bit). With this PR we'll have 17 different Sub<>Sub relays && the glue code is too similar && may be deduplicated.

@svyatonik svyatonik force-pushed the rialto-parachain-millau-messages-bridge branch 5 times, most recently from 37c4849 to b5cf74d Compare December 10, 2021 13:06
@svyatonik svyatonik force-pushed the rialto-parachain-millau-messages-bridge branch 3 times, most recently from 3040bce to 6aece4f Compare December 13, 2021 15:26
@fewensa
Copy link
Copy Markdown
Contributor

fewensa commented Mar 7, 2022

Hi, What plan of these pull requests (about parachain bridge)?

@svyatonik
Copy link
Copy Markdown
Contributor Author

Hi, What plan of these pull requests (about parachain bridge)?

It works (or at least it was working last time I was playing with it). There are some unhandled caveats in the parachain finality pallet, though - iirc they're marked with "TODO" in original PR.

Right now this para bridge is on hold, but we'll start pushing it soonish.

@svyatonik svyatonik force-pushed the rialto-parachain-millau-messages-bridge branch from 05d481c to f70587d Compare May 20, 2022 08:39
@svyatonik svyatonik marked this pull request as ready for review May 20, 2022 08:41
@svyatonik svyatonik enabled auto-merge (squash) May 20, 2022 08:41
@svyatonik svyatonik merged commit 0b2901a into master May 20, 2022
@svyatonik svyatonik deleted the rialto-parachain-millau-messages-bridge branch May 20, 2022 09:03
Copy link
Copy Markdown
Collaborator

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done an initial pass and didn't see anything flagrantly wrong. 👍

wuminzhe added a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Aug 8, 2022
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meta: Support running bridge on a parachain.

4 participants