Skip to content

fix: rococo initialization in the registry#297

Merged
TarikGul merged 4 commits intomainfrom
tarik-patch-rococo
Sep 26, 2023
Merged

fix: rococo initialization in the registry#297
TarikGul merged 4 commits intomainfrom
tarik-patch-rococo

Conversation

@TarikGul
Copy link
Copy Markdown
Member

@TarikGul TarikGul commented Sep 26, 2023

rel: #293

This ensures that the registry can initialize with rococo as the relay chain.

Important note:

In order to use rococo's asset hub with the AssetTransferApi one will need to hardcode the specName into the initialization like the following:

new AssetTransferApi(api, `asset-hub-rococo`, xcmVersion);

The reason being, kusama's asset hub and and rococo's asset-hub both share the same specName currently and will cause conflicts. We currently do an overewrite in the registry that the api uses and set the specName for rococo's asset hub to be asset-hub-rococo. This should be resolved at a higher level in the below PR for asset-hub's spec.

rel: paritytech/polkadot-sdk#1215

@TarikGul
Copy link
Copy Markdown
Member Author

TarikGul commented Sep 26, 2023

Im running into one issue that I can see will be a potential bug.

The specName for rococos asset-hub is also statemine... Which would cause a conflict in lookup.

@TarikGul TarikGul merged commit efbe7c3 into main Sep 26, 2023
@andrew-ifrita andrew-ifrita deleted the tarik-patch-rococo branch May 20, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants