fix: rococo initialization in the registry#297
Merged
Conversation
Member
Author
|
Im running into one issue that I can see will be a potential bug. The specName for |
Imod7
approved these changes
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rel: #293
This ensures that the registry can initialize with rococo as the relay chain.
Important note:
In order to use rococo's asset hub with the
AssetTransferApione will need to hardcode thespecNameinto the initialization like the following:The reason being, kusama's asset hub and and rococo's asset-hub both share the same specName currently and will cause conflicts. We currently do an overewrite in the registry that the api uses and set the
specNamefor rococo's asset hub to beasset-hub-rococo. This should be resolved at a higher level in the below PR for asset-hub's spec.rel: paritytech/polkadot-sdk#1215