Skip to content

feat: add rococo support and to the registry#293

Merged
TarikGul merged 2 commits intomainfrom
tarik-rococo-add
Sep 23, 2023
Merged

feat: add rococo support and to the registry#293
TarikGul merged 2 commits intomainfrom
tarik-rococo-add

Conversation

@TarikGul
Copy link
Copy Markdown
Member

@TarikGul TarikGul commented Sep 22, 2023

This adds rococo support to the registry

closes: #290

@TarikGul TarikGul requested review from Imod7 and bee344 September 22, 2023 18:18
Copy link
Copy Markdown
Contributor

@bee344 bee344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@TarikGul TarikGul merged commit 549abe8 into main Sep 23, 2023
@nikita-andrejevs
Copy link
Copy Markdown

Hello folks,

Seems the release is missing changes in src/registry/findRelayChain.ts.
There is no way to create an api instance for Rococo.

https://github.com/paritytech/asset-transfer-api/blob/main/src/registry/findRelayChain.ts#L11

@TarikGul
Copy link
Copy Markdown
Member Author

@nikita-andrejevs Thanks for reporting this, I am going to get this fixed a make a small patch release. Thanks again!

@TarikGul
Copy link
Copy Markdown
Member Author

TarikGul commented Sep 26, 2023

@nikita-andrejevs Added in this release: https://github.com/paritytech/asset-transfer-api/releases/tag/v0.1.2

Please read the release notes as there is an important nuance to using asset-hub-rococo.

@andrew-ifrita andrew-ifrita deleted the tarik-rococo-add branch May 20, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure Rococo gets added to the registry, and allows for injection.

3 participants