Skip to content

Conversation

@twoertwein
Copy link
Member

closes #666

pytest_warns_bounded becomes unused with this PR

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented May 1, 2023

OK, I tried this and it worked, so let's use this going forward. Can you convert it from Draft?

@Dr-Irv Dr-Irv mentioned this pull request May 1, 2023
2 tasks
@twoertwein twoertwein marked this pull request as ready for review May 1, 2023 15:44
@twoertwein
Copy link
Member Author

Could also remove pytest_warns_bounded?

Unrelated: could replace flake8 & flake8-pyi & pyupgrade with ruff, would speed up pre-commit and pandas did the same. Could also replace isort (pandas didn't do that as ruff doesn't support cython).

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @twoertwein

@Dr-Irv Dr-Irv merged commit cbd4134 into pandas-dev:main May 1, 2023
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented May 1, 2023

Could also remove pytest_warns_bounded?

We might need it if there are deprecation warnings in a current release that we are willing to tolerate.

Unrelated: could replace flake8 & flake8-pyi & pyupgrade with ruff, would speed up pre-commit and pandas did the same. Could also replace isort (pandas didn't do that as ruff doesn't support cython).

I'm not familiar with ruff, but would like to keep isort. Open to having you do a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nightly failures as of 4/29/2023, 10:15PM EST

2 participants