Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-746.v2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: fix
fix:
description: union with builtin variant name bug
links:
- https://github.com/palantir/conjure-python/pull/746
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public final class PythonIdentifierSanitizer {
"except",
"exec",
"finally",
"float",
"for",
"from",
"global",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,3 +172,9 @@ types:
alias: RecursiveObjectAlias
CollectionAliasExample:
alias: map<StringAliasExample, RecursiveObjectAlias>
UnionWithBuiltinVariantName:
union:
# the name of this variant is 'float' which conflicts with the python type 'float'
float: double
# the python type for this field is 'float' which conflicts with the variant name above
double: double

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.