Skip to content

fix(codegen): missing parens for in in for in loop init#7705

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-06-fix_codegen_missing_parens_for_in_in_for_in_loop_init
Dec 6, 2024
Merged

fix(codegen): missing parens for in in for in loop init#7705
graphite-app[bot] merged 1 commit intomainfrom
12-06-fix_codegen_missing_parens_for_in_in_for_in_loop_init

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 6, 2024

Well, this looks like an accidental change before, Context::empty().and_forbid_in(false) does nothing at all.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Dec 6, 2024

@github-actions github-actions bot added A-codegen Area - Code Generation C-bug Category - Bug labels Dec 6, 2024
@Dunqing Dunqing changed the title fix(codegen): missing parens for in in for in loop init fix(codegen): missing parens for in in for in loop init Dec 6, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #7705 will not alter performance

Comparing 12-06-fix_codegen_missing_parens_for_in_in_for_in_loop_init (8c3a954) with main (f7d41dd)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing requested a review from Boshen December 6, 2024 15:40
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 6, 2024
Copy link
Member

Boshen commented Dec 6, 2024

Merge activity

  • Dec 6, 10:51 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 6, 10:51 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 6, 10:59 AM EST: A user merged this pull request with the Graphite merge queue.

Well, this looks like an accidental change before, `Context::empty().and_forbid_in(false)` does nothing at all.
@Boshen Boshen force-pushed the 12-06-fix_codegen_missing_parens_for_in_in_for_loop_init branch from e10dad1 to 4afbe55 Compare December 6, 2024 15:52
@Boshen Boshen force-pushed the 12-06-fix_codegen_missing_parens_for_in_in_for_in_loop_init branch from 726205f to 8c3a954 Compare December 6, 2024 15:52
Base automatically changed from 12-06-fix_codegen_missing_parens_for_in_in_for_loop_init to main December 6, 2024 15:57
@graphite-app graphite-app bot merged commit 8c3a954 into main Dec 6, 2024
@graphite-app graphite-app bot deleted the 12-06-fix_codegen_missing_parens_for_in_in_for_in_loop_init branch December 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-codegen Area - Code Generation C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants