Skip to content

fix(codegen): missing parens for in in for loop init when it includes two binary expression#7703

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-06-fix_codegen_missing_parens_for_in_in_for_loop_init
Dec 6, 2024
Merged

fix(codegen): missing parens for in in for loop init when it includes two binary expression#7703
graphite-app[bot] merged 1 commit intomainfrom
12-06-fix_codegen_missing_parens_for_in_in_for_loop_init

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 6, 2024

close: #7690

I don't know the logic much, it works without left_ctx and no tests failed

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-codegen Area - Code Generation label Dec 6, 2024
Copy link
Member Author

Dunqing commented Dec 6, 2024

@github-actions github-actions bot added the C-bug Category - Bug label Dec 6, 2024
@Dunqing Dunqing changed the title fix(codegen): missing parens for in in for loop init fix(codegen): missing parens for in in for loop init when it includes two binary expression Dec 6, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #7703 will degrade performances by 3.37%

Comparing 12-06-fix_codegen_missing_parens_for_in_in_for_loop_init (4afbe55) with main (f7d41dd)

Summary

❌ 1 regressions
✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 12-06-fix_codegen_missing_parens_for_in_in_for_loop_init Change
semantic[cal.com.tsx] 28.1 ms 29.1 ms -3.37%

@overlookmotel overlookmotel requested a review from Boshen December 6, 2024 15:27
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 6, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Merge activity

…es two binary expression (#7703)

close: #7690

I don't know the logic much, it works without `left_ctx` and no tests failed
@Boshen Boshen force-pushed the 12-06-fix_codegen_missing_parens_for_in_in_for_loop_init branch from e10dad1 to 4afbe55 Compare December 6, 2024 15:52
@graphite-app graphite-app bot merged commit 4afbe55 into main Dec 6, 2024
@graphite-app graphite-app bot deleted the 12-06-fix_codegen_missing_parens_for_in_in_for_loop_init branch December 6, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-codegen Area - Code Generation C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

codegen: missing parens for in in for loop init

1 participant