Skip to content

fix(transformer/class-properties): transform delete chain expression in static prop initializers#7656

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-04-fix_transformer_class-properties_transform_delete_chain_expression_in_static_prop_initializers
Dec 5, 2024
Merged

fix(transformer/class-properties): transform delete chain expression in static prop initializers#7656
graphite-app[bot] merged 1 commit intomainfrom
12-04-fix_transformer_class-properties_transform_delete_chain_expression_in_static_prop_initializers

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 4, 2024

Follow-on after #7575. Annoyingly, we have to transform private fields in static prop initializers separately, to make sure the stack of private properties is in sync while visiting them.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Dec 4, 2024

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #7656 will not alter performance

Comparing 12-04-fix_transformer_class-properties_transform_delete_chain_expression_in_static_prop_initializers (ad76d1d) with main (6c82589)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 12-04-fix_transformer_class-properties_transform_delete_chain_expression_in_static_prop_initializers branch from b9bd478 to 9776930 Compare December 4, 2024 21:35
@overlookmotel overlookmotel marked this pull request as ready for review December 4, 2024 21:37
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
Copy link
Member

Dunqing commented Dec 5, 2024

Merge activity

  • Dec 4, 7:59 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 4, 7:59 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 4, 8:15 PM EST: A user merged this pull request with the Graphite merge queue.

…n in static prop initializers (#7656)

Follow-on after #7575. Annoyingly, we have to transform private fields in static prop initializers separately, to make sure the stack of private properties is in sync while visiting them.
@Dunqing Dunqing force-pushed the 12-04-refactor_transformer_class-properties_move_logic_for_handling_delete_of_chain_expression_into_transform_unary_expression_ branch from 2080da3 to 44fe854 Compare December 5, 2024 01:07
@Dunqing Dunqing force-pushed the 12-04-fix_transformer_class-properties_transform_delete_chain_expression_in_static_prop_initializers branch from 9776930 to ad76d1d Compare December 5, 2024 01:07
Base automatically changed from 12-04-refactor_transformer_class-properties_move_logic_for_handling_delete_of_chain_expression_into_transform_unary_expression_ to main December 5, 2024 01:12
@graphite-app graphite-app bot merged commit ad76d1d into main Dec 5, 2024
@graphite-app graphite-app bot deleted the 12-04-fix_transformer_class-properties_transform_delete_chain_expression_in_static_prop_initializers branch December 5, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants