feat(transformer/class-properties): transform ChainExpression#7575
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 4, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
ChainExpression
CodSpeed Performance ReportMerging #7575 will not alter performanceComparing Summary
Benchmarks breakdown
|
overlookmotel
approved these changes
Dec 4, 2024
Member
overlookmotel
left a comment
There was a problem hiding this comment.
Well this is a monster! I've not been through it in detail. Have just added a couple of commits for nits, and merging. Will look at it a bit more properly later.
Member
Merge activity
|
Fully support transforming ChainExpression in class properties. Our implementation has some differences in execution order compared to Babel, but we have passed all execution-related tests.
59e95ad to
c793d71
Compare
This was referenced Dec 4, 2024
overlookmotel
added a commit
that referenced
this pull request
Dec 4, 2024
Follow-on after #7575. By convention we use backticks for code snippets in doc comments.
Dunqing
pushed a commit
that referenced
this pull request
Dec 5, 2024
Follow-on after #7575. Small optimization. Replace recursive function calls with a loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fully support transforming ChainExpression in class properties. Our implementation has some differences in execution order compared to Babel, but we have passed all execution-related tests.