Skip to content

fix(linter/plugins): define RegExp.escape for tsc#20077

Open
overlookmotel wants to merge 1 commit intomainfrom
om/03-06-fix_linter_plugins_define_regexp.escape_for_tsc
Open

fix(linter/plugins): define RegExp.escape for tsc#20077
overlookmotel wants to merge 1 commit intomainfrom
om/03-06-fix_linter_plugins_define_regexp.escape_for_tsc

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 6, 2026

Fix a couple of errors that get flagged by TypeScript in VS Code, because it doesn't recognise RegExp.escape. Oxlint's typecheck doesn't flag it (presumably tsgo is aware of this new addition to the language), but it's still annoying having red squiggles in VS Code. This PR fixes that.

Copy link
Member Author

overlookmotel commented Mar 6, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this - tsgolint ships with es2025 types

@overlookmotel overlookmotel force-pushed the om/03-06-refactor_linter_plugins_debug_assert_that_values_passed_via_napi_are_not_undefined_ branch from 7c27819 to d80b305 Compare March 6, 2026 15:38
@overlookmotel overlookmotel force-pushed the om/03-06-fix_linter_plugins_define_regexp.escape_for_tsc branch from c587cb2 to 99c5d38 Compare March 6, 2026 15:38
@overlookmotel overlookmotel marked this pull request as ready for review March 6, 2026 15:52
Copilot AI review requested due to automatic review settings March 6, 2026 15:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@overlookmotel
Copy link
Member Author

overlookmotel commented Mar 6, 2026

I don't think we need this - tsgolint ships with es2025 types

Rationale is explained in PR description that I just added. Personally I think it's worthwhile, but if you disagree, feel free to close this - I don't care enough to argue!

@graphite-app graphite-app bot force-pushed the om/03-06-refactor_linter_plugins_debug_assert_that_values_passed_via_napi_are_not_undefined_ branch from d80b305 to f3aa4cd Compare March 6, 2026 16:10
@graphite-app graphite-app bot force-pushed the om/03-06-fix_linter_plugins_define_regexp.escape_for_tsc branch from 99c5d38 to 838872f Compare March 6, 2026 16:10
@overlookmotel overlookmotel force-pushed the om/03-06-fix_linter_plugins_define_regexp.escape_for_tsc branch from 838872f to 551dc4f Compare March 6, 2026 16:17
@overlookmotel overlookmotel force-pushed the om/03-06-refactor_linter_plugins_debug_assert_that_values_passed_via_napi_are_not_undefined_ branch from f3aa4cd to 2951baf Compare March 6, 2026 16:17
@overlookmotel overlookmotel changed the base branch from om/03-06-refactor_linter_plugins_debug_assert_that_values_passed_via_napi_are_not_undefined_ to graphite-base/20077 March 6, 2026 17:14
@overlookmotel overlookmotel force-pushed the om/03-06-fix_linter_plugins_define_regexp.escape_for_tsc branch from 551dc4f to ad532a4 Compare March 6, 2026 17:14
@overlookmotel overlookmotel force-pushed the om/03-06-fix_linter_plugins_define_regexp.escape_for_tsc branch from ad532a4 to ea87190 Compare March 6, 2026 17:37
@overlookmotel overlookmotel changed the base branch from graphite-base/20077 to om/03-06-docs_linter_plugins_move_comment_about_bivariance_hack_into_generated_code March 6, 2026 17:37
@overlookmotel overlookmotel force-pushed the om/03-06-docs_linter_plugins_move_comment_about_bivariance_hack_into_generated_code branch from 6e10dac to b434c6d Compare March 6, 2026 17:56
@overlookmotel overlookmotel force-pushed the om/03-06-fix_linter_plugins_define_regexp.escape_for_tsc branch from ea87190 to 9b85b9a Compare March 6, 2026 17:56
@graphite-app graphite-app bot changed the base branch from om/03-06-docs_linter_plugins_move_comment_about_bivariance_hack_into_generated_code to graphite-base/20077 March 6, 2026 18:12
@overlookmotel overlookmotel force-pushed the om/03-06-fix_linter_plugins_define_regexp.escape_for_tsc branch from 9b85b9a to 55b3301 Compare March 6, 2026 18:19
@overlookmotel overlookmotel changed the base branch from graphite-base/20077 to om/03-06-docs_linter_plugins_move_comment_about_bivariance_hack_into_generated_code March 6, 2026 18:19
@overlookmotel overlookmotel force-pushed the om/03-06-docs_linter_plugins_move_comment_about_bivariance_hack_into_generated_code branch from 50c0196 to caf1612 Compare March 6, 2026 18:19
@overlookmotel overlookmotel force-pushed the om/03-06-fix_linter_plugins_define_regexp.escape_for_tsc branch from 55b3301 to 0f1c0b1 Compare March 6, 2026 18:19
@graphite-app graphite-app bot changed the base branch from om/03-06-docs_linter_plugins_move_comment_about_bivariance_hack_into_generated_code to graphite-base/20077 March 6, 2026 18:27
@graphite-app graphite-app bot force-pushed the graphite-base/20077 branch from caf1612 to 2c0010a Compare March 6, 2026 18:35
@graphite-app graphite-app bot force-pushed the om/03-06-fix_linter_plugins_define_regexp.escape_for_tsc branch from 0f1c0b1 to 1033fa4 Compare March 6, 2026 18:35
@graphite-app graphite-app bot changed the base branch from graphite-base/20077 to main March 6, 2026 18:36
@graphite-app graphite-app bot force-pushed the om/03-06-fix_linter_plugins_define_regexp.escape_for_tsc branch from 1033fa4 to b9d192f Compare March 6, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants