fix(linter/plugins): define RegExp.escape for tsc#20077
Open
overlookmotel wants to merge 1 commit intomainfrom
Open
fix(linter/plugins): define RegExp.escape for tsc#20077overlookmotel wants to merge 1 commit intomainfrom
RegExp.escape for tsc#20077overlookmotel wants to merge 1 commit intomainfrom
Conversation
This was referenced Mar 6, 2026
Member
Author
camc314
reviewed
Mar 6, 2026
Contributor
camc314
left a comment
There was a problem hiding this comment.
I don't think we need this - tsgolint ships with es2025 types
7c27819 to
d80b305
Compare
c587cb2 to
99c5d38
Compare
Member
Author
Rationale is explained in PR description that I just added. Personally I think it's worthwhile, but if you disagree, feel free to close this - I don't care enough to argue! |
d80b305 to
f3aa4cd
Compare
99c5d38 to
838872f
Compare
838872f to
551dc4f
Compare
f3aa4cd to
2951baf
Compare
551dc4f to
ad532a4
Compare
This was referenced Mar 6, 2026
ad532a4 to
ea87190
Compare
1b6b61d to
6e10dac
Compare
6e10dac to
b434c6d
Compare
ea87190 to
9b85b9a
Compare
9b85b9a to
55b3301
Compare
b434c6d to
50c0196
Compare
50c0196 to
caf1612
Compare
55b3301 to
0f1c0b1
Compare
caf1612 to
2c0010a
Compare
0f1c0b1 to
1033fa4
Compare
1033fa4 to
b9d192f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix a couple of errors that get flagged by TypeScript in VS Code, because it doesn't recognise
RegExp.escape. Oxlint's typecheck doesn't flag it (presumably tsgo is aware of this new addition to the language), but it's still annoying having red squiggles in VS Code. This PR fixes that.