refactor(linter/plugins): clarify types by overlookmotel · Pull Request #20069 · oxc-project/oxc

overlookmotel · 2026-03-06T11:42:33Z

Small refactor. Import VisitorObject from where it's actually defined, instead of the alias in types.ts which renames it to Visitor. We also have a different type called Visitor so using the alias is a bit confusing.

overlookmotel · 2026-03-06T11:42:52Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Refactors the JS plugin visitor compiler typing to use VisitorObject from its generated source type, avoiding the confusing Visitor alias in plugins/types.ts (which clashes with other “Visitor” concepts).

Changes:

Replace Visitor type import (alias) with direct VisitorObject import from generated/visitor.d.ts.
Update addVisitorToCompiled signature to accept VisitorObject.

graphite-app · 2026-03-06T17:30:26Z

Merge activity

Mar 6, 5:30 PM UTC: camc314 added this pull request to the Graphite merge queue.
Mar 6, 5:46 PM UTC: Merged by the Graphite merge queue.

Small refactor. Import `VisitorObject` from where it's actually defined, instead of the alias in `types.ts` which renames it to `Visitor`. We also have a different type called `Visitor` so using the alias is a bit confusing.

This was referenced Mar 6, 2026

refactor(linter/plugins): enable TS strict option #19675

Merged

chore(apps, napi): restrict global types to NodeJS in tsconfig #20064

Closed

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Mar 6, 2026

overlookmotel mentioned this pull request Mar 6, 2026

fix(linter/plugins): fix type definition for VisitorObject #20065

Merged

github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Mar 6, 2026

This was referenced Mar 6, 2026

test(linter/plugins): add types test for VisitorObject #20066

Merged

refactor(linter/plugins): debug assert that values passed via NAPI are not undefined #20070

Merged

overlookmotel force-pushed the om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ branch from 63ddbdb to 8ee5a16 Compare March 6, 2026 14:37

overlookmotel force-pushed the om/03-06-refactor_linter_plugins_clarify_types branch from c0fdcb3 to 28b7eec Compare March 6, 2026 14:37

overlookmotel mentioned this pull request Mar 6, 2026

fix(linter/plugins): define RegExp.escape for tsc #20077

Open

overlookmotel force-pushed the om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ branch from 8ee5a16 to f88a63f Compare March 6, 2026 15:37

overlookmotel force-pushed the om/03-06-refactor_linter_plugins_clarify_types branch from 28b7eec to 33b8af5 Compare March 6, 2026 15:37

overlookmotel marked this pull request as ready for review March 6, 2026 15:47

overlookmotel requested a review from camc314 as a code owner March 6, 2026 15:47

Copilot AI review requested due to automatic review settings March 6, 2026 15:47

Copilot started reviewing on behalf of overlookmotel March 6, 2026 15:48 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

graphite-app bot force-pushed the om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ branch from f88a63f to e4f3e09 Compare March 6, 2026 16:09

graphite-app bot force-pushed the om/03-06-refactor_linter_plugins_clarify_types branch from 33b8af5 to 5f8e97f Compare March 6, 2026 16:09

overlookmotel force-pushed the om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ branch from e4f3e09 to cd83465 Compare March 6, 2026 16:17

overlookmotel force-pushed the om/03-06-refactor_linter_plugins_clarify_types branch from 5f8e97f to 35432f7 Compare March 6, 2026 16:17

This was referenced Mar 6, 2026

fix(linter/plugins): fix types for walkProgram and walkProgramWithCfg #20081

Merged

docs(linter/plugins): move comment about "bivariance hack" into generated code #20082

Merged

overlookmotel assigned camc314 Mar 6, 2026

camc314 approved these changes Mar 6, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 6, 2026

graphite-app bot changed the base branch from om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ to graphite-base/20069 March 6, 2026 17:30

overlookmotel force-pushed the om/03-06-refactor_linter_plugins_clarify_types branch from 35432f7 to dbd1cb6 Compare March 6, 2026 17:37

overlookmotel force-pushed the graphite-base/20069 branch from cd83465 to aacfef4 Compare March 6, 2026 17:37

overlookmotel changed the base branch from graphite-base/20069 to om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ March 6, 2026 17:37

Base automatically changed from om/03-06-test_linter_plugins_add_types_test_for_visitorobject_ to main March 6, 2026 17:38

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 6, 2026

refactor(linter/plugins): clarify types (#20069)

391ab14

Small refactor. Import `VisitorObject` from where it's actually defined, instead of the alias in `types.ts` which renames it to `Visitor`. We also have a different type called `Visitor` so using the alias is a bit confusing.

graphite-app bot force-pushed the om/03-06-refactor_linter_plugins_clarify_types branch from dbd1cb6 to 391ab14 Compare March 6, 2026 17:39

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 6, 2026

graphite-app bot merged commit 391ab14 into main Mar 6, 2026
19 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 6, 2026

graphite-app bot deleted the om/03-06-refactor_linter_plugins_clarify_types branch March 6, 2026 17:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(linter/plugins): clarify types#20069

refactor(linter/plugins): clarify types#20069
graphite-app[bot] merged 1 commit intomainfrom
om/03-06-refactor_linter_plugins_clarify_types

overlookmotel commented Mar 6, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Mar 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

overlookmotel commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

graphite-app bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

overlookmotel commented Mar 6, 2026 •

edited

Loading

overlookmotel commented Mar 6, 2026 •

edited

Loading

graphite-app bot commented Mar 6, 2026 •

edited

Loading