refactor(language-server): pass LanguageId to Tool::run_diagnostic and variants#19983
Draft
refactor(language-server): pass LanguageId to Tool::run_diagnostic and variants#19983
LanguageId to Tool::run_diagnostic and variants#19983Conversation
Co-authored-by: Sysix <[email protected]>
Copilot
AI
changed the title
[WIP] Refactor oxc_language_server crate and Tool trait
refactor(language-server): pass Mar 3, 2026
LanguageId to Tool::run_diagnostic and variants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Threads
LanguageIdthrough theTooltrait's diagnostic methods so tools can eventually use it for language-aware behavior. The language ID is currently ignored in all implementations — this is a pure refactor with no behavioral changes.Changes
Tooltrait (tool.rs): Addlanguage_id: &LanguageIdparameter torun_diagnostic,run_diagnostic_on_save,run_diagnostic_on_changeWorkspaceWorker(worker.rs): Threadlanguage_idthroughcollect_diagnostics_withand the three publicrun_diagnostic*methodsBackend(backend.rs): ExtractLanguageIdfrom the in-memory file system (or request params indid_open) at each call site; restructureddid_opento avoid an unnecessarylanguage_id.clone()ServerLinter(server_linter.rs): Accept_language_idparameter (ignored for now)FakeTool/ tests (tests.rs,worker.rs,tester.rs): Updated to match new signatures💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.