Skip to content

fix: add missing allowed category #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2021
Merged

fix: add missing allowed category #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions pkg/validation/internal/operatorhub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import (
// * "Database"
// * "Integration & Delivery"
// * "Logging & Tracing"
// * "Modernization & Migration"
// * "Monitoring"
// * "Networking"
// * "OpenShift Optional"
Expand Down Expand Up @@ -101,20 +102,21 @@ var validMediatypes = map[string]struct{}{
}

var validCategories = map[string]struct{}{
"AI/Machine Learning": {},
"Application Runtime": {},
"Big Data": {},
"Cloud Provider": {},
"Developer Tools": {},
"Database": {},
"Integration & Delivery": {},
"Logging & Tracing": {},
"Monitoring": {},
"Networking": {},
"OpenShift Optional": {},
"Security": {},
"Storage": {},
"Streaming & Messaging": {},
"AI/Machine Learning": {},
"Application Runtime": {},
"Big Data": {},
"Cloud Provider": {},
"Developer Tools": {},
"Database": {},
"Integration & Delivery": {},
"Logging & Tracing": {},
"Monitoring": {},
"Modernization & Migration": {},
Copy link

@tlwu2013 tlwu2013 Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we keep this category list in alphabetical order?

Copy link
Contributor

@exdx exdx Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: go fmt?

"Networking": {},
"OpenShift Optional": {},
"Security": {},
"Storage": {},
"Streaming & Messaging": {},
}

func validateOperatorHub(objs ...interface{}) (results []errors.ManifestResult) {
Expand Down
1 change: 1 addition & 0 deletions pkg/validation/internal/removed_apis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const minKubeVersionWarnMessage = "csv.Spec.minKubeVersion is not informed. It i

// K8s version where the apis v1betav1 is no longer supported
const k8sVerV1betav1Unsupported = "1.22.0"

// K8s version where the apis v1betav1 was deprecated
const k8sVerV1betav1Deprecated = "1.16.0"

Expand Down