-
Notifications
You must be signed in to change notification settings - Fork 79
fix: add missing allowed category #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing allowed category #164
Conversation
|
/lgtm |
| // * "Security" | ||
| // * "Storage" | ||
| // * "Streaming & Messaging" | ||
| // * "Modernization & Migration" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should we keep this category list in alphabetical order?
| "Security": {}, | ||
| "Storage": {}, | ||
| "Streaming & Messaging": {}, | ||
| "Modernization & Migration": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should we keep this category list in alphabetical order?
exdx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this category -- must have missed this originally
| "Security": {}, | ||
| "Storage": {}, | ||
| "Streaming & Messaging": {}, | ||
| "Modernization & Migration": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: go fmt?
|
Hi @exdx, Thank you for the review. |
|
/lgtm |
dinhxuanvu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
That was checked with the Prod Owner and this category should be allowed.