Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

Description

That was checked with the Prod Owner and this category should be allowed.

@openshift-ci openshift-ci bot requested review from dinhxuanvu and exdx October 13, 2021 11:14
@gallettilance
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
// * "Security"
// * "Storage"
// * "Streaming & Messaging"
// * "Modernization & Migration"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we keep this category list in alphabetical order?

"Security": {},
"Storage": {},
"Streaming & Messaging": {},
"Modernization & Migration": {},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we keep this category list in alphabetical order?

Copy link
Contributor

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this category -- must have missed this originally

"Security": {},
"Storage": {},
"Streaming & Messaging": {},
"Modernization & Migration": {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: go fmt?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2021
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Oct 16, 2021

Hi @exdx,

Thank you for the review.
All done. Could you help us get this one merged?

@exdx
Copy link
Contributor

exdx commented Oct 18, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2021
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2021
@openshift-merge-robot openshift-merge-robot merged commit 37561c9 into operator-framework:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants