docs: add code comments and improve documentation clarity for string encoding#1463
Closed
Copilot wants to merge 4 commits intodudantas/refactor-string-encoding-to-lib-utf8cppfrom
Closed
docs: add code comments and improve documentation clarity for string encoding#1463Copilot wants to merge 4 commits intodudantas/refactor-string-encoding-to-lib-utf8cppfrom
Copilot wants to merge 4 commits intodudantas/refactor-string-encoding-to-lib-utf8cppfrom
Conversation
Replaced manual UTF-8 and Latin-1 encoding logic in stdext::string.cpp with utf8cpp for improved correctness and cross-platform consistency. Updated CMake and vcpkg configuration to require utf8cpp. Added documentation on string encoding policy and comprehensive unit tests for encoding/decoding and validation functions.
dudantas
force-pushed
the
dudantas/refactor-string-encoding-to-lib-utf8cpp
branch
from
15e5f57 to
b0c222a
Compare
- Added detailed comments explaining control character filtering logic in utf8_to_latin1 - Added error handling comments to all conversion functions - Updated function documentation in string.h to clarify error behavior - Enhanced string-encoding-policy.md with error handling strategy and precise character filtering details - Added additional test cases for edge cases (empty string, NULL bytes, Latin-1 boundaries) Co-authored-by: dudantas <8551443+dudantas@users.noreply.github.com>
…encoding Co-authored-by: dudantas <8551443+dudantas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor string encoding to use utf8cpp and add tests
docs: add code comments and improve documentation clarity for string encoding
Nov 20, 2025
|
Member
|
Only the unit tests were reusable; the rest is disposable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review identified missing documentation for control character filtering logic and error handling behavior in the string encoding refactor.
Code Comments
utf8_to_latin1(filters 0x00-0x1F and 0x80-0x9F except tab/CR/LF)API Documentation
string.hwith brief descriptions of error behaviorstring-encoding-policy.mddocumenting empty-string-on-error conventionTest Coverage
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.