update the Raspbian to Debian 12 Bookworm to support Raspi 5

[yangsong-cnyn]

This PR updates the Raspbian OS from Debian 10 Buster to Debian 12 Bookworm. This change is necessary to add support for the Raspberry Pi 5, which requires the Bookworm release.

This OS update introduces several related changes:

1. Python Virtual Environment: Debian 12 enforces PEP 668, which prevents the installation of Python packages into the system-wide environment using pip. To comply with this, the setup script now creates and uses a Python virtual environment (venv) for installing dependencies.

2. Updated China Mirror: The APT source for the Tsinghua mirror has been updated to point to the bookworm repositories, ensuring users in China can download packages efficiently.

3. Prefix Delegation Configuration: For Thread 1.4 builds, the configuration is updated to use the OpenThread DHCPv6 PD client (OTBR_DHCP6_PD_CLIENT=openthread), and systemd-networkd with its internal PD client disabled, for Thread PD.

[EskoDijk]

Issue #92 can be linked to this PR! (I don't have rights to do this.)

[gemini-code-assist]

Code Review

This pull request updates the Raspbian image from Debian Buster to Debian 12 Bookworm, primarily to add support for Raspberry Pi 5. The changes involve updating the image URL, adjusting package installations, and modifying APT sources for the new distribution.

Overall, the changes align with the goal of supporting Bookworm. However, there are a few critical and medium severity issues that need addressing, particularly concerning the validity of the new image URL and a typo in a script. Additionally, some dependency changes require clarification.

Summary of Findings

• Potentially Invalid Raspberry Pi OS Image URL: The RASPIOS_URL in script/make-raspbian.bash (line 91) points to an image dated 2024-11-19, which appears to be a future date. This URL might be invalid and needs verification to ensure it points to a stable, released Bookworm image.
• Critical Typo in Script Execution Permissions: A typo chmog instead of chmod exists in script/otbr-setup.bash (line 257). This will prevent /etc/rc.local from being made executable, which is a critical failure for its intended operation.
• Unclear Rationale for DHCPV6_PD_REF=1 Removal: The DHCPV6_PD_REF=1 option was removed in script/otbr-setup.bash (e.g., former line 178) for REFERENCE_RELEASE_TYPE="1.4" builds. Clarification is needed on whether this is intentional due to deprecation, incompatibility with Bookworm, or other reasons.
• Unclear Rationale for PyGObject Removal: The PyGObject Python package installation was removed from script/otbr-setup.bash (former line 235). The reason for this removal (e.g., no longer needed, transitive dependency, conflicts) should be clarified.
• Risk from Unpinned nrfutil Version: The nrfutil Python package version was unpinned in script/otbr-setup.bash (line 247). This could lead to future build instabilities if newer nrfutil versions introduce breaking changes. Confirmation of intent and testing is advised.
• Python Virtual Environment Adoption: The introduction of a Python virtual environment (.venv-otbr) in script/otbr-setup.bash (lines 225-226) is a good practice for dependency management.
• Updated wiringpi Installation Method: The change in script/otbr-setup.bash (lines 250-251) to install wiringpi via direct download and dpkg is a necessary adaptation for Debian Bookworm, as wiringpi is often not available in standard APT repositories for newer OS versions.
• Minor Stylistic Changes (Not commented due to settings): Some minor stylistic changes were made, such as adding blank lines in README.md (lines 48, 56) and adjusting spacing in a case statement in script/make-firmware.bash (line 187). These improve readability but were not commented on directly due to review settings instructing to only comment on medium, high, or critical issues.

Merge Readiness

This pull request makes important updates for Debian Bookworm support. However, due to the critical issues identified (potentially invalid image URL and a script typo), and several medium-severity items requiring clarification, I recommend that these changes be addressed before merging. I am unable to approve pull requests, but based on this review, changes are requested. Please ensure these points are resolved and the build process is thoroughly tested with the corrected scripts and a valid image URL.

[EskoDijk]

The CI build error here looks like the one I've commented on here: #126 (comment) ; it now affects builds on every OS I tried except Ubuntu 20.04.
~Two weeks ago it still worked on newer OSes for me. And it's not due to recent code changes: even older commits don't build anymore on newer OSes.