Skip to content

[OSDEV-1886] Pre-initialization of a variable #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Innavin369 merged 2 commits into from
Apr 3, 2025
Merged

[OSDEV-1886] Pre-initialization of a variable #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
611a081
Init variable
roninzp Apr 3, 2025
b635101
fix steps dependency
roninzp Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/destroy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
destroy_lambda_edge_function:
runs-on: ubuntu-latest
environment: ${{ inputs.deploy-env }}
needs: clean_ecr_repositories
steps:
- name: Get Environment Name for ${{ vars.ENV_NAME }}
id: get_env_name
Expand All @@ -60,7 +61,7 @@ jobs:
destroy:
runs-on: ubuntu-latest
environment: ${{ inputs.deploy-env }}
needs: clean_ecr_repositories
needs: destroy_lambda_edge_function
steps:
- name: Get Environment Name for ${{ vars.ENV_NAME }}
id: get_env_name
Expand Down
1 change: 1 addition & 0 deletions deployment/delete_lambda
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ ENV_NAME=$1
CLOUDFRONT_DOMAIN=$2
LAMBDA_ARN="arn:aws:lambda:$REGION:$ACCOUNT_ID:function:funcOpenSupplyHub${ENV_NAME}RedirectToS3origin"
LAMBDA_VERSION=$(aws lambda list-versions-by-function --function-name "$LAMBDA_ARN" --region "$REGION" | jq -r '.Versions | max_by(.Version) | .Version')
DISTRIBUTION_ID=""

for id in $(aws cloudfront list-distributions --query "DistributionList.Items[*].Id" --output text); do
domains=$(aws cloudfront get-distribution-config --id $id --query "DistributionConfig.Aliases.Items" --output text)
Expand Down