[OSDEV-1886] Pre-initialization of a variable

[roninzp]

Pre-initialization of a variable.
The sequence of steps in the pipeline has been corrected.

[VadimKovalenkoSNF]

Approved.

[coderabbitai]

📝 Walkthrough

Walkthrough

The change introduces a new variable DISTRIBUTION_ID in the deployment/delete_lambda script, initialized as an empty string. This variable is utilized to store the CloudFront distribution ID that corresponds to the specified CLOUDFRONT_DOMAIN. The script now includes logic to check for multiple distributions; if more than one is detected, it prints an error message and exits with status 1, while the overall control flow remains unchanged.

Changes

File	Change Summary
deployment/delete_lambda	Added new variable DISTRIBUTION_ID (initialized to an empty string). Introduced logic to check if multiple CloudFront distributions match the domain; prints an error and exits with code 1 if more than one distribution is found.
.github/workflows/destroy.yml	Updated job dependencies: destroy_lambda_edge_function now depends on clean_ecr_repositories; destroy now depends on destroy_lambda_edge_function.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Script
    participant CloudFront

    User->>Script: Execute delete_lambda script
    Script->>CloudFront: Query distributions matching CLOUDFRONT_DOMAIN
    CloudFront-->>Script: Return list of distributions
    alt Single distribution found
        Script->>Script: Proceed with update
    else Multiple distributions found
        Script->>User: Display error message
        Script->>Script: Exit with status 1
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 611a081 and b635101.

📒 Files selected for processing (1)

• .github/workflows/destroy.yml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: run-flake8-linter
• GitHub Check: run-integration-test-code-quality
• GitHub Check: run-dd-code-quality
• GitHub Check: run-countries-code-quality
• GitHub Check: run-contricleaner-code-quality
• GitHub Check: get-base-branch-dd-cov
• GitHub Check: get-base-branch-django-cov
• GitHub Check: get-base-branch-countries-cov
• GitHub Check: get-base-branch-contricleaner-cov
• GitHub Check: run-django-code-quality

🔇 Additional comments (3)

.github/workflows/destroy.yml (3)

39-43: Dependency Ordering in destroy_lambda_edge_function Job
The addition of needs: clean_ecr_repositories ensures that the ECR repositories are cleaned up before attempting to destroy the Lambda@Edge function. This dependency is logical and increases the robustness of the destroy workflow.

---

61-65: Updated Dependency in destroy Job
Changing the dependency from clean_ecr_repositories to destroy_lambda_edge_function ensures that the Lambda@Edge function is fully destroyed before proceeding with broader environment cleanup. This sequential ordering better reflects the necessary resource teardown steps.

---

53-59: Lambda@Edge Destruction Command Check
The workflow step invoking ./deployment/delete_lambda ${{ vars.ENV_NAME }} ${{ vars.CLOUDFRONT_DOMAIN }} is still relevant. Please ensure that the recent pre-initialization of the DISTRIBUTION_ID variable within the deployment/delete_lambda script properly integrates with this call, especially if it affects how the script identifies and handles CloudFront distributions.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[barecheck]

React App | Jest test suite - Code coverage report

Total: 33.18%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[VadimKovalenkoSNF]

Approved

[barecheck]

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 56.14%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[barecheck]

Contricleaner App | Unittest test suite - Code coverage report

Total: 98.91%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[barecheck]

Countries App | Unittest test suite - Code coverage report

Total: 100%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[barecheck]

Django App | Unittest test suite - Code coverage report

Total: 80.65%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered