Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/release/RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html
### Bugfix
* [OSDEV-1806](https://opensupplyhub.atlassian.net/browse/OSDEV-1806) - Refactored the Parent Company field validation. The field is now validated as a regular character field.
* [OSDEV-1787](https://opensupplyhub.atlassian.net/browse/OSDEV-1787) - The tooltip messages for the Claim button have been removed for all statuses of moderation events on the `Contribution Record` page and changed according to the design on `Thanks for adding data for this production location` pop-up.
* [OSDEV-1789](https://opensupplyhub.atlassian.net/browse/OSDEV-1789) - Fixed an issue where the scroll position was not resetting to the top when navigating through SLC workflow pages.

### Release instructions:
* Ensure that the following commands are included in the `post_deployment` command:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import SearchByOsIdTab from './SearchByOsIdTab';
import SearchByNameAndAddressTab from './SearchByNameAndAddressTab';
import RequireAuthNotice from '../RequireAuthNotice';
import { makeContributeProductionLocationStyles } from '../../util/styles';
import { useResetScrollPosition } from '../../util/hooks';

const TAB_OS_ID = 'os-id';
const TAB_NAME_ADDRESS = 'name-address';
Expand All @@ -32,6 +33,8 @@ const ContributeProductionLocation = ({
VALID_TABS.includes(tabInQuery) ? tabInQuery : TAB_NAME_ADDRESS,
);

useResetScrollPosition(location);

useEffect(() => {
if (VALID_TABS.includes(tabInQuery)) {
setSelectedTab(tabInQuery);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import RequireAuthNotice from '../RequireAuthNotice';
import StyledSelect from '../Filters/StyledSelect';
import RequiredAsterisk from '../RequiredAsterisk';
import { productionLocationInfoStyles } from '../../util/styles';
import { useResetScrollPosition } from '../../util/hooks';
import {
countryOptionsPropType,
facilityProcessingTypeOptionsPropType,
Expand Down Expand Up @@ -138,9 +139,7 @@ const ProductionLocationInfo = ({
setParentCompany('');
};

useEffect(() => {
window.scrollTo(0, 0);
}, [location]);
useResetScrollPosition(location);

const inputData = useMemo(
() => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
import history from '../../util/history';
import { productionLocationPropType } from '../../util/propTypes';
import { makeSearchByNameAndAddressResultStyles } from '../../util/styles';
import { useResetScrollPosition } from '../../util/hooks';

const SearchByNameAndAddressResult = ({
data: productionLocations,
Expand All @@ -33,6 +34,8 @@ const SearchByNameAndAddressResult = ({
const TITLE = 'Production Location Search';
const location = useLocation();

useResetScrollPosition(location);

useEffect(() => {
const searchParams = new URLSearchParams(location.search);
const name = searchParams.get('name');
Expand Down
6 changes: 5 additions & 1 deletion src/react/src/components/Contribute/SearchByOsIdResult.jsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { useEffect } from 'react';
import { useHistory, useParams } from 'react-router-dom';
import { useHistory, useParams, useLocation } from 'react-router-dom';
import { connect } from 'react-redux';
import isEmpty from 'lodash/isEmpty';
import { object, bool, func } from 'prop-types';
Expand All @@ -16,6 +16,7 @@ import {
} from '../../actions/contributeProductionLocation';
import { contributeProductionLocationRoute } from '../../util/constants';
import { makeSearchByOsIdResultStyles } from '../../util/styles';
import { useResetScrollPosition } from '../../util/hooks';
import { productionLocationPropType } from '../../util/propTypes';

import BackToSearchButton from './BackToSearchButton';
Expand All @@ -33,8 +34,11 @@ const SearchByOsIdResult = ({
}) => {
const TITLE = 'Production Location Search';
const history = useHistory();
const location = useLocation();
const { osID } = useParams();

useResetScrollPosition(location);

useEffect(() => {
if (osID) {
fetchProductionLocation(osID);
Expand Down
6 changes: 6 additions & 0 deletions src/react/src/util/hooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -374,3 +374,9 @@ export const useFileUploadHandler = ({

return { fileInput };
};

export const useResetScrollPosition = location => {
useEffect(() => {
window.scrollTo(0, 0);
}, [location]);
};